SlipMode waveform visual for RGB GLSL

[acolombier]

This is an attempt to address the missing slip mode visual feature as requested in #8136

Other renderer will be addressed in different PRs.

TODO:

• Render marker on the slip position part of the wave form upside down
• Render the Post/pre roll

[JoergAtGithub]

Did you consider to draw the whole waveform twice, half height stacked on each other?
I would use the indicator colors of the spinnies (white and orange) also on the waveform.

[acolombier]

Did you consider to draw the whole waveform twice, half height stacked on each other?

That was my first thought, yes, but I quickly decided against as I thought synchronising animation between the two would probably be more work that extend the renderer with more visual abilities. I guess if we factor in the implementation on each renderers, it might turns out to be less work.

I would use the indicator colors of the spinnies (white and orange) also on the waveform.

Do you mean for the breathing animation around the slip point waveform? If yes, definitely agree: I've just hacked something together for now with a hardcoded ugly green, just wanted to gather some feedback before getting to work on something more polished :)

[m0dB]

Nice that you are addressing this!

I had a hard time understand what was happening looking at the screen capture, and in the end I realised why: the start of track triangles are not part of the slip mode (which beat positions is). Is that intentional?

How about another approach: draw the slipping waveform on top, using waveformrenderersimple, so it is a single color, which 50% transparency.

Some comments (note, without looking at the code, so I don't know your current approach, it might very well be along the lines):

Assuming the rendering with the normal play position and the slip position is done in the same waveform widget (and I think it should), there is no need to do any synchronisation.

In waveformwidgetrenderer.cpp:

    double truePlayPos = m_visualPlayPosition->getAtNextVSync(vsyncThread);

you can call

    m_pVisualPlayPos->getPlaySlipAtNextVSync(vSyncThread, &truePlayPos, &slipPlayPos);

and you will get both positions synchronised.

The widget has a stack of renderers, and you can easily add more renderers to this stack to render the slip mode, and tell these renderers to use the slipPlayPos instead of the truePlayPos. When not in slip mode, you just skip all those renderers. You can then decide whether you want to only render the waveform itself for the slip mode, or (part of the) additional layers as well, or whether you want them to overlay with transparency or draw them tiled. In other words, it would equally allow to do what I am seeing in the screen capture, what Joerg is proposing and what I am proposing.

Apart from the synchronisation, using a single waveform widget with additional renderers makes sense because play mode and slip mode share a lot of information that is part of the widget (the waveform!), but also there is overhead in using a multiple widgets, as each has it's own QOpenGLWindow, so I would avoid that. (I have been thinking of using a single QOpenGLWindow for multiple WGLWidgets when possible: When multiple WGLWidgets combined occupy a single rectangle)

Let me know if this explanation is clear enough.

[acolombier]

I had a hard time understand what was happening looking at the screen capture

That's my fault. I've tested with that dummy audio file I use to test waveform correctness (monotonous tone from 20Hhz to 20Khz).

the start of track triangles are not part of the slip mode

Yep I hadn't had implemented the pre/postroll triangle just yet. I just gave it a stab now (still incomplete with part of track missing on the slip waveform)

Kooha-2024-03-26-13-38-26.mp4

How about another approach: draw the slipping waveform on top, using waveformrenderersimple, so it is a single color, which 50% transparency.

Just to check I understood correctly, do you mean having it on top of the play waveform with transparency? I can think of two problem with this:

• I might be hard to "recognise" the track with the section of track covering each other
• (currently missing for the screen record but in my plans) The cues which will be displayed on the slip waveform are likely to also be hard to distinguish. We could make them look differently too (color, transparency) but things like label may also make the visual bloated

I guess it could be great to have renderer using different look for the slip visuals? Since it looks like renderer should implement this, I guess there is no technical limitation to make it look different in various waveform, so users may also gain more value out of using different renderers

you can call

    m_pVisualPlayPos->getPlaySlipAtNextVSync(vSyncThread, &truePlayPos, &slipPlayPos);

Cool, that's exactly what I'm using :)

The widget has a stack of renderers, and you can easily add more renderers to this stack to render the slip mode, and tell these renderers to use the slipPlayPos instead of the truePlayPos. When not in slip mode, you just skip all those renderers. You can then decide whether you want to only render the waveform itself for the slip mode, or (part of the) additional layers as well, or whether you want them to overlay with transparency or draw them tiled. In other words, it would equally allow to do what I am seeing in the screen capture, what Joerg is proposing and what I am proposing.

Sounds good. I will look at how easy to remove the currently hardcoded references to playPos and instead use an arbitrary pos for all the renderer

Let me know if this explanation is clear enough.

Thanks, that was very clear.

[acolombier]

I just rewrote everything using your feedback and I think it looks much better, simpler and easier! Let me know your thoughts (visual available on Zulip)

[m0dB]

Yes, this is the approach I had in mind! Nice!

[acolombier]

I would use the indicator colors of the spinnies (white and orange) also on the waveform.

I have set the same orange as the ghost spinny cursor for LateNight PaleMoon and red-ish for Classic, other themes default to a light grey, but happy to put some custom color if you have suggestion!

[ronso0]

Let me know your thoughts (visual available on Zulip)

This looks really good!

[daschuer]

Thank you for this nice new feature. I have added some comments for improving readability.

[daschuer]

Is using the root namespace :: required here? If yes we should workaround this name clash.

[acolombier]

Yes it - WaveformRendererAbstract is defined both in src/waveform/renderers/waveformrendererabstract.h and src/waveform/renderers/allshader/waveformrendererabstract.h. Perhaps worth addressing the name conflict in another PR?

[daschuer]

Unfortunately a conflict has been developed.

[daschuer]

LGTM, Thank you.

[acolombier]

Conflict solved now

[daschuer]

Thank you for this nice eye candy.

[fwcd]

Love this feature! The only oddity I've noticed is that the markers also "shift" to the bottom half when using a waveform that doesn't support this split view in slip mode:

Screen.Recording.2024-07-22.at.17.15.47.mov

[acolombier]

This is due the work we had started with @m0dB to mutualise all the allshader waveform - I will try to finish implementing the effect on the other waveform type now that it should be easier!

[acolombier]

Created #13499 to keep track!