Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: Bundle resources for preloading when targeting Emscripten/WASM #12922

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 5, 2024

This is the final piece in the puzzle to getting Mixxx to successfully launch in the browser1.

Emscripten provides a virtual file system as described in https://emscripten.org/docs/porting/files/packaging_files.html. Since our WASM binary is already pretty heavy (304M) I went with the preloading option for now, which bundles our res directory in a single mixxx.data (96M), located at /res within the virtual file system. qResourcePath is also updated to use this path when targeting Emscripten.

Footnotes

  1. Of course there is still a lot of work ahead to make this run well

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thank you.

@daschuer daschuer merged commit ca84095 into mixxxdj:main Mar 5, 2024
13 checks passed
@fwcd fwcd deleted the wasm-resources branch March 5, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants