update libdjinterop to 0.20.2

[Be-ing]

to fix Clang build
xsco/libdjinterop#112

[Be-ing]

Linking libdjinterop fails on Windows when built via ExternalProject_Add?? PR to update vcpkg is here: microsoft/vcpkg#36869

[daschuer]

This does unfortunately not link on windows:
fatal error LNK1120: 8 unresolved externals

I think It would be reasonable to stick with the VCPKG provided version for now and just add your change as patch. PATCH_COMMAND

Other option would be to required 0.20.1 but download 0.20.2
We need also make sure that the djinterop PPA has the newest version in this case.

[Be-ing]

The update of libdjinterop in vcpkg has been merged.

[daschuer]

Do you have an idea why we have a linker error on Windows? Will the same happen with the vcpkg build?

[Be-ing]

It may have to do with this https://github.com/xsco/libdjinterop/blob/main/CMakeLists.txt#L156

set_target_properties(DjInterop PROPERTIES C_VISIBILITY_PRESET hidden)
set_target_properties(DjInterop PROPERTIES CXX_VISIBILITY_PRESET hidden)

which makes me wonder how it works with vcpkg 🤔 Anyway, considering that it worked with vcpkg before somehow, I think it will work again when updating vcpkg.

[Be-ing]

Let's update vcpkg then try rebasing this.

[daschuer]

@mr-smidge Can you please you Launchpad PPA to 0.20.2? Than we can advance with Mixxx to that version. Thank you.

[mr-smidge]

@mr-smidge Can you please you Launchpad PPA to 0.20.2? Than we can advance with Mixxx to that version. Thank you.

I've pushed 0.20.2, and bionic is building now... will copy for other distros tomorrow once it's done.

[daschuer]

Thank you

[mr-smidge]

0.20.2 now available for all Ubuntu series: https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+packages

[daschuer]

Merged via #12898
Thank you.

[Be-ing]

That was to the main branch. This needs to go to the 2.4 branch to fix the build failure.

[JoergAtGithub]

Merged in #13154