Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pioneer DDJ-FLX4 mapping improvements #12842

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Pioneer DDJ-FLX4 mapping improvements #12842

merged 3 commits into from
Feb 18, 2024

Conversation

grizeldi
Copy link
Contributor

2 improvements to the built in FLX4 mapping:

  1. Controller now properly exits Bluetooth pairing mode while connected to Mixxx.
  2. Removed the mapping for the software headphone gain knob, as the knob on the controller already affects hardware gain, which resulted in very sensitive gain knob (as discussed in the last couple messages of Pioneer DDJ-FLX4: New mapping base on DDJ-400 #11245).

The behavior of headphone cueing and mixing now seems to be consistent with how FLX4 works with Rekordbox.

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@grizeldi
Copy link
Contributor Author

Done. Apple complicating things for devs again I see 😅

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you.

res/controllers/Pioneer-DDJ-FLX4-script.js Outdated Show resolved Hide resolved
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 909ab3c into mixxxdj:main Feb 18, 2024
10 checks passed
@Swiftb0y
Copy link
Member

too quick yet again, this should've gone into 2.4... whats the procedure? cherry-pick to backport?

@daschuer
Copy link
Member

Yes.

Swiftb0y added a commit that referenced this pull request Feb 18, 2024
Pioneer DDJ-FLX4 mapping improvements
@Swiftb0y
Copy link
Member

thank you. done

@grizeldi grizeldi deleted the flx4-improvements branch February 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants