Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks: select track row when clicking the preview button (only when starting preview) #12791

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 11, 2024

Low prio, draft until we discussed if that is desired or conflicts with library use cases.

Selects the Preview row if Preview button is clicked to start previewing, no seletion change if preview is stopped.

The use case mentioned in #12789 is

  • click Preview
  • scroll right to read metadata in offscreen columns
  • have some highlight to keep track of the row

Quoting myself:

I can't imagine why one would like to keep the current selection when clicking the preview button. On the contrary, that would simplify loading that track to a deck (with Return key if double-click is configured accordingly in the Library preferences, Mixxx 2.4)

I think simply selecting the row is predictable (consistency with other columns).
Some other highlight is certainly feasible but overkill IMHO.

@ronso0 ronso0 changed the title Tracks: select track row when clicking the preview button Tracks: select track row when clicking the preview button (only when starting preview) Feb 11, 2024
@ronso0 ronso0 force-pushed the lib-preview-select-row branch from bca0165 to 568bde1 Compare February 14, 2024 20:50
@ronso0 ronso0 marked this pull request as ready for review March 4, 2024 00:08
@ronso0 ronso0 added this to the 2.4.1 milestone Mar 4, 2024
@ronso0 ronso0 modified the milestones: 2.4.1, 2.4.2 Apr 13, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@daschuer daschuer merged commit cbdef08 into mixxxdj:2.4 Apr 22, 2024
14 checks passed
@daschuer daschuer modified the milestones: 2.4.2, 2.4.1 Apr 22, 2024
@ronso0 ronso0 deleted the lib-preview-select-row branch April 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants