Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlModel: avoid duplicates in developer tools window #12707

Merged
merged 1 commit into from
Feb 1, 2024
Merged

ControlModel: avoid duplicates in developer tools window #12707

merged 1 commit into from
Feb 1, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 31, 2024

No description provided.

@ronso0 ronso0 mentioned this pull request Jan 31, 2024
Merged
@ronso0 ronso0 requested a review from Swiftb0y January 31, 2024 12:19
Swiftb0y
Swiftb0y reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid there is no solution that would be able to avoid the temporary container. I'd prefer a different implementation though.

src/control/controlmodel.cpp Show resolved Hide resolved
src/control/controlmodel.cpp Show resolved Hide resolved
@ronso0 ronso0 marked this pull request as draft January 31, 2024 13:16
ronso0
ronso0 commented Jan 31, 2024
View reviewed changes
src/control/controlmodel.cpp Outdated Show resolved Hide resolved
@ronso0 ronso0 force-pushed the controls-no-duplicates branch from 11e9cad to 3958df3 Compare February 1, 2024 00:41
@ronso0 ronso0 marked this pull request as ready for review February 1, 2024 01:18
Swiftb0y
Swiftb0y approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a bandaid fix.

@Swiftb0y Swiftb0y merged commit 82c0ba2 into mixxxdj:2.4 Feb 1, 2024
14 checks passed
@ronso0
Copy link
Member Author

ronso0 commented Feb 1, 2024

Shall I add a TODO, maybe someone wants to fix it another way?

@Swiftb0y
Copy link
Member

Swiftb0y commented Feb 1, 2024

I'm not seeing any trivial way. May make sense to filter before constructing the return value of ControlDoublePrivate::getAllInstances() but that just moves the necessary temporary container. I don't see any way to avoid that easily.

@ronso0 ronso0 deleted the controls-no-duplicates branch February 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @Swiftb0y