DlgPrefInterface: Disable tooltips on iOS by default

[fwcd]

These are usually more obtrusive than helpful on touchscreens, especially when covering other controls, therefore this PR disables them, by default, on iOS.

[JoergAtGithub]

Is the OS the appropriated criteria here? Shouldn't it be screen size, or screen size + touch instead? This also applies to RPi etc.

[fwcd]

Screen size would be debatable IMO, touch seems reasonable, but remember that this is only a default value and setting it depending on whether there's a mouse currently connected doesn't make much sense IMO (or would lead to surprising behavior with missing tooltips once the user connects one).

If we'd want to go this route, we would likely have to dynamically update this option based on screen size/connected input devices etc. Such a mechanism would be a lot more complex to implement than this fix, which is safe to apply given that all iOS devices use a touchscreen as their primary input.

We could implement a more complex system in future PRs, but I'd consider that out of scope for this small UX improvement which is trivial to replace.

[ronso0]

I'm wondering, how are tooltips triggered on touch devices?
Does the pointer remain on the last touch point?

Did you intend to disable tooltips altogether?
If so, there's also

mixxx/src/mixxxmainwindow.cpp

Line 96 in def8d15

m_toolTipsCfg(mixxx::TooltipsPreference::TOOLTIPS_ON) {

and

mixxx/src/mixxxmainwindow.cpp

Lines 168 to 174 in def8d15

	// Set the visibility of tooltips, default "1" = ON
	m_toolTipsCfg = static_cast<mixxx::TooltipsPreference>(
	pConfig->getValue(ConfigKey("[Controls]", "Tooltips"),
	static_cast<int>(mixxx::TooltipsPreference::TOOLTIPS_ON)));
	#ifdef MIXXX_USE_QOPENGL
	ToolTipQOpenGL::singleton().setActive(m_toolTipsCfg == mixxx::TooltipsPreference::TOOLTIPS_ON);
	#endif

and

mixxx/src/mixxxmainwindow.cpp

Lines 1132 to 1155 in def8d15

	bool MixxxMainWindow::eventFilter(QObject* obj, QEvent* event) {
	if (event->type() == QEvent::ToolTip) {
	// always show tooltips in the preferences window
	QWidget* activeWindow = QApplication::activeWindow();
	if (activeWindow &&
	QLatin1String(activeWindow->metaObject()->className()) !=
	"DlgPreferences") {
	// return true for no tool tips
	switch (m_toolTipsCfg) {
	case mixxx::TooltipsPreference::TOOLTIPS_ONLY_IN_LIBRARY:
	if (dynamic_cast<WBaseWidget*>(obj) != nullptr) {
	return true;
	}
	break;
	case mixxx::TooltipsPreference::TOOLTIPS_ON:
	break;
	case mixxx::TooltipsPreference::TOOLTIPS_OFF:
	return true;
	default:
	DEBUG_ASSERT(!"m_toolTipsCfg value unknown");
	return true;
	}
	}
	}

[fwcd]

I couldn't get tooltips to trigger reliably, usually they would pop up on the last tapped control after I've already tapped something else, but only every now and then (just often enough to become a minor annoyance, because they seem to block touches to the underlying UI).

Did you intend to disable tooltips altogether?
If so, there's also ...

Ah interesting, I didn't know about those! I think it's reasonable to leave it opt-in for now, that way adventurous users could still enable them manually in the settings (or users wishing to connect a mouse to their iOS device), even if the vast majority likely won't find them useful on iOS.

[fwcd]

Can we move forward with this PR or is there a reason we should hold off on this fix?

[ronso0]

LGTM, I think slotResetToDefaults() should be adjusted accordingly?

[fwcd]

Updated, thanks

[ronso0]

Thank you, looks good!