Clamp offset in VisualPlayPosition with extra time of two vsync interval #12470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this is required to not clamp in all good conditions. Clamping causes a jittery waveform and must not happen under normal conditions
|
@m0dB can you confirm this fix? |
|
looks good to me, at least I don't notice any regression. |
|
Shouldn't we log a warning, if this clamping happens? |
|
the warning is now in place. |
|
LGTM! Thank you! |
|
Why might want to limit the logging of these warnings... |
|
There is already a boolean intended to avoid log spam. Each warning is indicating a stucked waveform and a visible stutter. If you see them all the time without transport issues it indicates broken syncing. I have no idea how to remove this spam without removing the warning altogether. I think it is better to fix the root cause if we can. On Linux I was not able to produce a single warning. A first step would be to make this warning more verbose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that this is required to not clamp in all good conditions. Clamping causes a jittery waveform and must not happen under normal conditions.
This removes one cause of jittery waveforms, during my tests. All other tests where successful with reasonable values. So I guess that the remaining jitters are real vsync misses.
The clamping has been introduced to not move the waveform with a stalled audio engine. This still works, but is done one vsync cycle later.