mp3 garbage detection fix #12464
Merged
mp3 garbage detection fix #12464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents to abort decoding when files have some garbage similar to a valid header.
|
Could you extract this section of the mp3 file, to use it as test case for all sound sources, that support MP3? |
|
Is main the right target for this bugfix? |
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@acolombier has provided a file with some garbage at the beginning here #11923
Due to a missing sanity check, libmad fails to decode the file with an insane high bit rate. There is a similar check for Layer III but in this case Layer I was read from the garbage leads to bypassing the check.
I have added the check now in the Mixxx code and I can now play the file without any issues.
The same check for layer III can be found here:
https://github.com/markjeee/libmad/blob/c2f96fa4166446ac99449bdf6905f4218fb7d6b5/frame.c#L286