Notarization: Migrate script to notarytool
#12119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These didn't print the environment variable that was unset, but substituted in the (unset) variable instead.
Swiftb0y
reviewed
Oct 15, 2023
5 tasks
|
Moved to #12123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12089
As per the official migration guide. In principle everything should work as-is, but I'll mark this as a draft for now for some more testing. Since notarization fails on 2.4 and
main, we might have to generate new passwords anyway.To do
--waitflagnotarytool log ...if a submission fails