-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to libdjinterop 0.20.0 #12005
Conversation
Supports Engine OS/desktop up to 3.2.0, the current latest version.
BTW, this version is already merge upstream VCPKG: microsoft/vcpkg#33884 |
Thank you. Why is this a draft PR? |
Just wanted to make sure all the checks passed 😄 - but if we're feeling confident, now it's no longer draft! |
@daschuer, if you're happy with this PR then please copy libdjinterop 0.20.0 to the relevant Mixxx PPA - thank you! |
There are still 437 warnings with MSVC, most of them are sourced from djinterop. |
I've raised a dedicated ticket xsco/libdjinterop#107 for this. Most warnings appear to come from the 3rd-party library sqlite_modern_cpp, which is bundled with libdjinterop - I'll try to silence these ones and properly fix the genuine ones in libdjinterop. |
Thank you. We can merge this independently, right? |
Yes we can 😁 ! |
We use the source package form Launchpad already: Line 2147 in 44a9972
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to test that, but I see no reason to reject that update. Thank you very much.
Supports Engine OS/desktop up to 3.2.0, the current latest version.
The changes from 0.19.2 are minimal: the new DB schema (v2.21.0) has been added, which adds a new table (
SmartPlaylist
) but does not modify anything else. As such, I believe there is a very low risk of any regressions.