Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to libdjinterop 0.20.0 #12005

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

mr-smidge
Copy link
Contributor

@mr-smidge mr-smidge commented Sep 20, 2023

Supports Engine OS/desktop up to 3.2.0, the current latest version.

The changes from 0.19.2 are minimal: the new DB schema (v2.21.0) has been added, which adds a new table (SmartPlaylist) but does not modify anything else. As such, I believe there is a very low risk of any regressions.

Supports Engine OS/desktop up to 3.2.0, the current latest version.
@github-actions github-actions bot added the build label Sep 20, 2023
@JoergAtGithub
Copy link
Member

BTW, this version is already merge upstream VCPKG: microsoft/vcpkg#33884

@Swiftb0y
Copy link
Member

Thank you. Why is this a draft PR?

@mr-smidge
Copy link
Contributor Author

Thank you. Why is this a draft PR?

Just wanted to make sure all the checks passed 😄 - but if we're feeling confident, now it's no longer draft!

@mr-smidge mr-smidge marked this pull request as ready for review September 20, 2023 23:01
@mr-smidge
Copy link
Contributor Author

@daschuer, if you're happy with this PR then please copy libdjinterop 0.20.0 to the relevant Mixxx PPA - thank you!
https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+packages

@daschuer
Copy link
Member

There are still 437 warnings with MSVC, most of them are sourced from djinterop.
Do you see a chance to fix them?

@mr-smidge
Copy link
Contributor Author

There are still 437 warnings with MSVC, most of them are sourced from djinterop. Do you see a chance to fix them?

I've raised a dedicated ticket xsco/libdjinterop#107 for this. Most warnings appear to come from the 3rd-party library sqlite_modern_cpp, which is bundled with libdjinterop - I'll try to silence these ones and properly fix the genuine ones in libdjinterop.

@daschuer
Copy link
Member

Thank you. We can merge this independently, right?

@mr-smidge
Copy link
Contributor Author

Thank you. We can merge this independently, right?

Yes we can 😁 !

@daschuer
Copy link
Member

We use the source package form Launchpad already:

"https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+sourcefiles/libdjinterop/${LIBDJINTEROP_VERSION}-0ubuntu1/libdjinterop_${LIBDJINTEROP_VERSION}.orig.tar.gz"

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test that, but I see no reason to reject that update. Thank you very much.

@daschuer daschuer merged commit c94360d into mixxxdj:2.4 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants