-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove offensive language (Pt. 4) #11968
Conversation
Do we need an alias system for tooltip IDs for backwards-compat with third-party skins? I hope not. |
I don't think so. Would be nice to have, but the effort is not worth it IMO. There's a skin warning logged in case of 'invalid' tooltip ids (which needlessly contains the entire file path of legacyskinparser.cpp). Whta do you think? |
Apart from that the changes LGTM (as good as they can when looking at a diff of 112 files ;), and I'm now checking the skins for obvious regressions. |
@@ -27,7 +27,7 @@ namespace mixxx { | |||
/// libraries, we need to convert between the two values. | |||
/// | |||
/// See this for details: | |||
/// https://github.com/Holzhaus/serato-tags/blob/master/docs/colors.md#track-colors | |||
/// https://github.com/Holzhaus/serato-tags/blob/main/docs/colors.md#track-colors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, wouldn't it be better to move this to a Mixxx repo/branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM
This is part of #11931 and contains mostly tooltip and skin changes, as well as replacing some remaining occurrences.