Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offensive language (Pt. 4) #11968

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

Holzhaus
Copy link
Member

This is part of #11931 and contains mostly tooltip and skin changes, as well as replacing some remaining occurrences.

@Holzhaus
Copy link
Member Author

Do we need an alias system for tooltip IDs for backwards-compat with third-party skins? I hope not.

@Holzhaus Holzhaus added this to the 2.4.0 milestone Sep 11, 2023
@ronso0
Copy link
Member

ronso0 commented Sep 12, 2023

I don't think so. Would be nice to have, but the effort is not worth it IMO. There's a skin warning logged in case of 'invalid' tooltip ids (which needlessly contains the entire file path of legacyskinparser.cpp).
What might be helpful for 3rd-party skin users/developers would be a link to the respective tooltip migration commit (in the changelog maybe?), because, for tooltip ids, we probably won't have something like the 'deprecated, use XX instead' hint in manual > Mixxx controls, it's too much effort and tbh I don't know where to put that so it's actually more discoverable than a link in the changelog.

Whta do you think?

@ronso0
Copy link
Member

ronso0 commented Sep 12, 2023

Apart from that the changes LGTM (as good as they can when looking at a diff of 112 files ;), and I'm now checking the skins for obvious regressions.

@@ -27,7 +27,7 @@ namespace mixxx {
/// libraries, we need to convert between the two values.
///
/// See this for details:
/// https://github.com/Holzhaus/serato-tags/blob/master/docs/colors.md#track-colors
/// https://github.com/Holzhaus/serato-tags/blob/main/docs/colors.md#track-colors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, wouldn't it be better to move this to a Mixxx repo/branch?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@ronso0 ronso0 merged commit a7615ea into mixxxdj:2.4 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants