Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for common-hid-packet-parser.js #11925

Merged

Conversation

JoergAtGithub
Copy link
Member

@JoergAtGithub JoergAtGithub commented Sep 5, 2023

-TypedArray is no public JS keyword, we need to list them all, not only for createDataView, but also for it's callers
-Last 3 arguments of addControl are optional (but were not defined this way in JSDoc)
-length argument of parsePacket is only needed for a warning message -> make it optional

The other changes are automatic reformatting by pre-commit(including the removal of default values for optional arguments)

…ly for createDataView, but also for it's callers

-Last 3 arguments of addControl are optional (but was not defined this way in JSDoc)
-length argument of parsePacket is only needed for a warning message -> make it optional
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@daschuer daschuer merged commit 6577cb0 into mixxxdj:2.4 Sep 6, 2023
@daschuer daschuer added this to the 2.4.0 milestone Sep 6, 2023
@JoergAtGithub JoergAtGithub deleted the minorFixesForCommonHidPacketParser branch September 6, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants