Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable WARNINGS_FATAL on macOS, too #11905

Merged
merged 1 commit into from
Sep 1, 2023
Merged

ci: Enable WARNINGS_FATAL on macOS, too #11905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
- name: Ubuntu 22.04
os: ubuntu-22.04
cmake_args: >-
-DWARNINGS_FATAL=ON
-DQT6=ON
-DBULK=ON
-DFFMPEG=ON
Expand All @@ -40,7 +39,6 @@ jobs:
- name: Ubuntu 22.04 (QML)
os: ubuntu-22.04
cmake_args: >-
-DWARNINGS_FATAL=ON
-DQT6=ON
-DQML=ON
-DBULK=ON
Expand Down Expand Up @@ -113,7 +111,6 @@ jobs:
# also adjust the for the local Windows build setup in
# ./tools/windows_buildenv.bat
cmake_args: >-
-DWARNINGS_FATAL=ON
-DBULK=OFF
-DFFMPEG=OFF
-DHSS1394=ON
Expand Down Expand Up @@ -284,6 +281,7 @@ jobs:
cmake ${{ matrix.cmake_args }} ${{ env.CMAKE_ARGS_EXTRA }}
-DCMAKE_BUILD_TYPE=RelWithDebInfo
-DCMAKE_PREFIX_PATH="${{ env.CMAKE_PREFIX_PATH }}"
-DWARNINGS_FATAL=ON
-DDEBUG_ASSERTIONS_FATAL=OFF
-DBATTERY=ON
-DBROADCAST=ON
Expand Down
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2854,6 +2854,11 @@ if(COREAUDIO)
src/sources/v1/legacyaudiosourceadapter.cpp
lib/apple/CAStreamBasicDescription.cpp
)
set_property(
SOURCE lib/apple/CAStreamBasicDescription.cpp
APPEND_STRING
PROPERTY COMPILE_OPTIONS -Wno-deprecated-anon-enum-enum-conversion
)
target_compile_definitions(mixxx-lib PRIVATE __COREAUDIO__)
target_include_directories(mixxx-lib SYSTEM PUBLIC lib/apple)
endif()
Expand Down