Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calc of first beatgrid bar in Engine export #11815

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix calc of first beatgrid bar in Engine export #11815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/library/export/engineprimeexportjob.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ bool tryGetBeatgrid(BeatsPointer pBeats,

int numBeatsToCue = pBeats->numBeatsInRange(firstBeatPlayPos, cueBeatPlayPos);
const auto firstBarAlignedBeatPlayPos = pBeats->findNBeatsFromPosition(
cueBeatPlayPos, numBeatsToCue & ~0x3);
cueBeatPlayPos, -1 * (numBeatsToCue & ~0x3));
Copy link
Contributor Author

@mr-smidge mr-smidge Aug 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a blunder... this code has been unchanged for a long time, but it was mistakenly trying to find the first bar in the track by scanning forwards instead of backwards.

This resulted in the beatgrid being calculated more and more inaccurately the further forward the main cue point was in the track.

if (!firstBarAlignedBeatPlayPos.isValid()) {
return false;
}
Expand Down