Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for Mixxx 2.3.6 #11784

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Aug 3, 2023

No description provided.

CHANGELOG.md Outdated
Comment on lines 35 to 36
* Protobuf: Fexed building with v23.4
[#11751](https://github.com/mixxxdj/mixxx/pull/11751)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Protobuf: Fexed building with v23.4
[#11751](https://github.com/mixxxdj/mixxx/pull/11751)
* Protobuf: Fixed building with v23.4
[#11751](https://github.com/mixxxdj/mixxx/pull/11751)

@daschuer
Copy link
Member Author

daschuer commented Aug 3, 2023

Fixed and integrated latest merge.

The 2.3.6 release and "closing" of the 2.3 branch is a prerequisite for a 2.4 release.

I think we should follow a deadline driven, but "no regression" strategy.
From that point of view
Theses Issues are blocking the release:
#11545
#11785

There are some more PRs targeted the 2.3 branch, nice to have but they can go to 2.4.1 in favor of not stretching the deadline.

Does that sound reasonable?

(Will cosponsor that on Zulip)

@daschuer daschuer added this to the 2.3.6 milestone Aug 5, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
daschuer and others added 2 commits August 6, 2023 07:17
Co-authored-by: Jan Holthuis <[email protected]>
Co-authored-by: Jan Holthuis <[email protected]>
@daschuer
Copy link
Member Author

daschuer commented Aug 6, 2023

Done.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@daschuer
Copy link
Member Author

daschuer commented Aug 6, 2023

Done + new entry recently merged.

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Holzhaus Holzhaus requested a review from Swiftb0y August 7, 2023 09:05
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the PR and for the review

@Swiftb0y Swiftb0y merged commit b0737ac into mixxxdj:2.3 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants