increase maximum waveform zoom out level

[Be-ing]

As requested by a user. I have found myself staring at overview waveforms to know when a transition is coming, which is not what the overviews are for. Zooming the waveforms out further should help with that.

It would also be nice if the current play position relative to the widget's length could be adjusted. It is more important to see what is coming than what has already played, so it would be good to set this 1/4 or 1/3 from the left. There is a Launchpad ticket for that.

[Be-ing]

I tested setting the max level even higher and I think that beyond 10% the user may as well be looking at the overview waveform. As the waveform is zoomed out, the beat marker lines stay the same width and get closer together, so they become distracting.

[SaturnusDJ]

Thanks.
Is there a compile available with this? I can't build currently.

[Be-ing]

If you use Windows, you can download AppVeyor's build. I'm not sure if Travis keeps the builds for Mac and GNU/Linux. When this is merged, the Mixxx build server will build it for all platforms and put it online.

[Be-ing]

Can someone test this?

[SaturnusDJ]

Sure I would love to. Though, it would save me a lot of time if anyone has a build ready somewhere.

[daschuer]

There is a small issue here

mixxx/src/mixer/basetrackplayer.cpp

Line 90 in 2055c37

m_pWaveformZoom->setStepCount(WaveformWidgetRenderer::s_waveformMaxZoom -

    m_pWaveformZoom->setStepCount(WaveformWidgetRenderer::s_waveformMaxZoom -
WaveformWidgetRenderer::s_waveformMinZoom);

from 1 ... 10 we have 10 steps. This formula results in 9.
But there seams to be an additional issue. Because the Deere Zoom buttons have 7 steps, and I cannot reach the minimum.

[Be-ing]

Because the Deere Zoom buttons have 7 steps, and I cannot reach the minimum.

You can use the mouse scroll wheel to zoom or set the default zoom level in the preferences. I will fix this in #940 to avoid merge conflicts.

[daschuer]

Is the issue related to the skin? It looks like the Deere button are directly connected to COs.

[Be-ing]

Hm, maybe it is a bug in ControlPotmeter or ControlPotmeterBehavior?

[Be-ing]

I think the problem is that the waveform_zoom CO is a ControlPotmeter, not that something is wrong with ControlPotmeter. I'll change it to a plain ControlObject and manually create the waveform_zoom_up/down COs.

[daschuer]

I did not understand why potmeter not works, but who cares. Now it is working and the interface is not changed. If one has the time to have a deeper look, we can fix it. I will file a bug at Launchpad.

[daschuer]

Here it is:
https://bugs.launchpad.net/mixxx/+bug/1678441
The rest LGTM.
Thank you for the work.

[Be-ing]

I don't entirely understand either. It had something to do with scaling between [set/get][value/parameter].

[SaturnusDJ]

Cross-post from https://bugs.launchpad.net/mixxx/+bug/1656209

I've just seen the new zoom levels in v2.1. Am I doing something wrong? It seems that there is barely more too see. I can see ahead for only 30 beats. I've put the preferences at max zoom out (10%). As originally said, requesting to be able to see ahead for about 200 beats.