CMakeSettings.json: start with a copy of a UTF-8-BOM file. #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JosepMaJAZ Could you've a look. If I remind correct, the original code was added by you. |
|
If the resulting CMakeSettings.json is not changed binary by this patch, it should be save to merge. |
|
It's an interesting solution. I guess this way it should not get damaged. |
… encoded batch file.
|
CI is working now |
|
@JoergAtGithub can we merge this now? |
|
I tested this and it works for me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with a UTF-8-BOM file removes the non ASCII Characters form the ASCII + code page encoded batch file.
These turns out to get lost regularly.