AnalyzerWaveformTest refactoring as a foundation for more tests #11488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Apr 17, 2023
Comment on lines
+37
to
+45
| for (std::size_t i = 0; i < kCanarySize; i++) { | ||
| m_canaryBigBuf[i] = kCanaryFloat; | ||
| } | ||
| for (std::size_t i = kCanarySize; i < kCanarySize + kBigBufSize; i++) { | ||
| m_canaryBigBuf[i] = kMagicFloat; | ||
| } | ||
| for (std::size_t i = kCanarySize + kBigBufSize; i < 2 * kCanarySize + kBigBufSize; i++) { | ||
| m_canaryBigBuf[i] = kCanaryFloat; | ||
| } |
There was a problem hiding this comment.
memset() works with char arrays only. We can do a lot more refactoring here, but I like to stop at this point.
The whole test is kind of pointless, because the buffer is passed to the analyzer as const. So there must be went a lot of things wrong to make this test fail. Maybe it was relevant for an early version of the analyzer? We may consider to remove it. |
Swiftb0y
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step is to add a test the compares the resulting waveform.