Fix reset Main/Intro/Outro behaviour #11482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition will come back anyway after reloading the track and the forced analysis. Now a reanalysis is no longer nacessary.
ronso0
approved these changes
May 2, 2023
|
@mixxxdj/developers Anyone else cares to take a look? |
Swiftb0y
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of #11448 I have discovered an issue with the "Reset" context menu.
After resetting Main Intro or Auto cue the disappear instead of reset to their default position. They are temporary removed, which is kind of pointless, because they will re-appear if the track is loaded again. The user has no chance to verify the new position without ejecting and loading the track again. The track is then reanalyzed and after that the new position appears.
The reanalysis is pointless because the removed cues will appear at the exact same position as after the first analysis depending on the Audible Sound cue, which is immutable like the waveform.
The only use case where the Audible Sound changes is after the track samples have been changed. In this case the Waveform, where you can also spot the Audible Sound range needs to be reanalyzed as well. To make sure waveform and Audible Sound cue are always consistent, I have changed that the Audible Sound cue is now reset along with the wave forms.
I consider this PR a bug fix and that's why it is for the 2.3 branch. However we may consider to merge it to 2.4 because it changes the behavior of the reset menu slightly.