-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): improve mono-compatibility for Rubberband R3. #11418
Conversation
2046ea7
to
ae537d5
Compare
I have issued a PR against upstream VCPK to update to rubberband 3.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
@atskler Can you confirm that this change is sufficient?
First my distro/repo should update rubberband to v3.2, after that I can check it. |
My distro will never get R3 so I built it myself: |
My will get it as it is a rolling release distro. |
No, the resulting sound will just not be mono-compatible with a lower rubberband version. |
Ok than let's merge it. Thank you for all the testing. |
Rubberband 3.2 is available for my distro so I built Mixxx and checked it and it solved the problem. |
…compat feat(engine): improve mono-compatibility for Rubberband R3.
…compat feat(engine): improve mono-compatibility for Rubberband R3.
…compat feat(engine): improve mono-compatibility for Rubberband R3.
…compat feat(engine): improve mono-compatibility for Rubberband R3.
…compat feat(engine): improve mono-compatibility for Rubberband R3.
Fixes #11361
Huge thanks to @atskler for noticing the issue and reporting it to us and upstream, as well as @cannam for doing the actual hard work of fixing the problem.