Fix a memory leak and use override and default for build in effects

src/effects/backends/builtin/autopaneffect.cpp

@@ -75,9 +75,6 @@ void AutoPanEffect::loadEngineEffectParameters(
     m_pWidthParameter = parameters.value("width");
 }
 
-AutoPanEffect::~AutoPanEffect() {
-}
-
 void AutoPanEffect::processChannel(
         AutoPanGroupState* pGroupState,
         const CSAMPLE* pInput,
@@ -168,7 +165,8 @@ void AutoPanEffect::processChannel(
         pGroupState->frac.setWithRampingApplied(static_cast<float>((sinusoid + 1.0f) / 2.0f));
 
         // apply the delay
-        pGroupState->delay->process(&pInput[i],
+        pGroupState->pDelay->process(
+                &pInput[i],
                 &pOutput[i],
                 -0.005 *
                         math_clamp(

src/effects/backends/builtin/autopaneffect.h

@@ -64,23 +64,23 @@ static constexpr int panMaxDelay = 3300; // allows a 30 Hz filter at 97346;
 class AutoPanGroupState : public EffectState {
   public:
     AutoPanGroupState(const mixxx::EngineParameters& engineParameters)
-            : EffectState(engineParameters) {
-        time = 0;
-        delay = new EngineFilterPanSingle<panMaxDelay>();
-        m_dPreviousPeriod = -1.0;
-    }
-    ~AutoPanGroupState() {
+            : EffectState(engineParameters),
+              time(0),
+              pDelay(std::make_unique<EngineFilterPanSingle<panMaxDelay>>()),
+              m_dPreviousPeriod(-1.0) {
     }
+    ~AutoPanGroupState() override = default;
+
     unsigned int time;
     RampedSample frac;
-    EngineFilterPanSingle<panMaxDelay>* delay;
+    std::unique_ptr<EngineFilterPanSingle<panMaxDelay>> pDelay;
     double m_dPreviousPeriod;
 };
 
 class AutoPanEffect : public EffectProcessorImpl<AutoPanGroupState> {
   public:
     AutoPanEffect() = default;
-    virtual ~AutoPanEffect();
+    ~AutoPanEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/balanceeffect.cpp

@@ -79,9 +79,6 @@ BalanceGroupState::BalanceGroupState(const mixxx::EngineParameters& engineParame
     m_high->setStartFromDry(true);
 }
 
-BalanceGroupState::~BalanceGroupState() {
-}
-
 void BalanceGroupState::setFilters(int sampleRate, double freq) {
     m_low->setFrequencyCorners(sampleRate, freq);
     m_high->setFrequencyCorners(sampleRate, freq);
@@ -94,9 +91,6 @@ void BalanceEffect::loadEngineEffectParameters(
     m_pBypassFreqParameter = parameters.value("bypassFreq");
 }
 
-BalanceEffect::~BalanceEffect() {
-}
-
 void BalanceEffect::processChannel(
         BalanceGroupState* pGroupState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/balanceeffect.h

@@ -10,7 +10,7 @@
 class BalanceGroupState : public EffectState {
   public:
     BalanceGroupState(const mixxx::EngineParameters& engineParameters);
-    ~BalanceGroupState();
+    ~BalanceGroupState() override = default;
 
     void setFilters(int sampleRate, double freq);
 
@@ -29,7 +29,7 @@ class BalanceGroupState : public EffectState {
 class BalanceEffect : public EffectProcessorImpl<BalanceGroupState> {
   public:
     BalanceEffect() = default;
-    virtual ~BalanceEffect();
+    ~BalanceEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/bessel4lvmixeqeffect.h

@@ -22,7 +22,7 @@ class Bessel4LVMixEQEffectGroupState : public LVMixEQEffectGroupState<EngineFilt
 class Bessel4LVMixEQEffect : public EffectProcessorImpl<Bessel4LVMixEQEffectGroupState> {
   public:
     Bessel4LVMixEQEffect();
-    virtual ~Bessel4LVMixEQEffect();
+    ~Bessel4LVMixEQEffect() override;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/bessel8lvmixeqeffect.h

@@ -24,7 +24,7 @@ class Bessel8LVMixEQEffectGroupState : public LVMixEQEffectGroupState<EngineFilt
 class Bessel8LVMixEQEffect : public EffectProcessorImpl<Bessel8LVMixEQEffectGroupState> {
   public:
     Bessel8LVMixEQEffect();
-    virtual ~Bessel8LVMixEQEffect();
+    ~Bessel8LVMixEQEffect() override;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/biquadfullkilleqeffect.h

@@ -18,6 +18,7 @@
 class BiquadFullKillEQEffectGroupState : public EffectState {
   public:
     BiquadFullKillEQEffectGroupState(const mixxx::EngineParameters& engineParameters);
+    ~BiquadFullKillEQEffectGroupState() override = default;
 
     void setFilters(
             mixxx::audio::SampleRate sampleRate,
@@ -59,6 +60,7 @@ class BiquadFullKillEQEffectGroupState : public EffectState {
 class BiquadFullKillEQEffect : public EffectProcessorImpl<BiquadFullKillEQEffectGroupState> {
   public:
     BiquadFullKillEQEffect();
+    ~BiquadFullKillEQEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/bitcrushereffect.cpp

@@ -56,10 +56,6 @@ void BitCrusherEffect::loadEngineEffectParameters(
     m_pDownsampleParameter = parameters.value("downsample");
 }
 
-BitCrusherEffect::~BitCrusherEffect() {
-    //qDebug() << debugString() << "destroyed";
-}
-
 void BitCrusherEffect::processChannel(
         BitCrusherGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/bitcrushereffect.h

@@ -16,15 +16,18 @@ struct BitCrusherGroupState : public EffectState {
               hold_r(0),
               accumulator(1) {
     }
-    CSAMPLE hold_l, hold_r;
+    ~BitCrusherGroupState() override = default;
+
+    CSAMPLE hold_l;
+    CSAMPLE hold_r;
     // Accumulated fractions of a samplerate period.
     CSAMPLE accumulator;
 };
 
 class BitCrusherEffect : public EffectProcessorImpl<BitCrusherGroupState> {
   public:
     BitCrusherEffect() = default;
-    virtual ~BitCrusherEffect();
+    ~BitCrusherEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/distortioneffect.h

@@ -11,6 +11,7 @@
 class DistortionGroupState : public EffectState {
   public:
     DistortionGroupState(const mixxx::EngineParameters& engineParameters);
+    ~DistortionGroupState() override = default;
 
     CSAMPLE_GAIN m_driveGain;
     CSAMPLE m_crossfadeParameter;
@@ -23,6 +24,7 @@ class DistortionGroupState : public EffectState {
 class DistortionEffect : public EffectProcessorImpl<DistortionGroupState> {
   public:
     DistortionEffect() = default;
+    ~DistortionEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/echoeffect.h

@@ -22,6 +22,7 @@ class EchoGroupState : public EffectState {
         audioParametersChanged(engineParameters);
         clear();
     }
+    ~EchoGroupState() override = default;
 
     void audioParametersChanged(const mixxx::EngineParameters& engineParameters) {
         delay_buf = mixxx::SampleBuffer(kMaxDelaySeconds *
@@ -49,6 +50,7 @@ class EchoGroupState : public EffectState {
 class EchoEffect : public EffectProcessorImpl<EchoGroupState> {
   public:
     EchoEffect() = default;
+    ~EchoEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/filtereffect.cpp

@@ -85,10 +85,6 @@ void FilterEffect::loadEngineEffectParameters(
     m_pHPF = parameters.value("hpf");
 }
 
-FilterEffect::~FilterEffect() {
-    //qDebug() << debugString() << "destroyed";
-}
-
 void FilterEffect::processChannel(
         FilterGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/filtereffect.h

@@ -12,7 +12,7 @@
 
 struct FilterGroupState : public EffectState {
     FilterGroupState(const mixxx::EngineParameters& engineParameters);
-    ~FilterGroupState();
+    ~FilterGroupState() override;
 
     void setFilters(int sampleRate, double lowFreq, double highFreq);
 
@@ -28,7 +28,7 @@ struct FilterGroupState : public EffectState {
 class FilterEffect : public EffectProcessorImpl<FilterGroupState> {
   public:
     FilterEffect() = default;
-    virtual ~FilterEffect();
+    ~FilterEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/flangereffect.cpp

@@ -108,10 +108,6 @@ void FlangerEffect::loadEngineEffectParameters(
     m_pTripletParameter = parameters.value("triplet");
 }
 
-FlangerEffect::~FlangerEffect() {
-    //qDebug() << debugString() << "destroyed";
-}
-
 void FlangerEffect::processChannel(
         FlangerGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/flangereffect.h

@@ -35,6 +35,8 @@ struct FlangerGroupState : public EffectState {
         SampleUtil::clear(delayLeft, kBufferLenth);
         SampleUtil::clear(delayRight, kBufferLenth);
     }
+    ~FlangerGroupState() override = default;
+
     CSAMPLE delayLeft[kBufferLenth];
     CSAMPLE delayRight[kBufferLenth];
     unsigned int delayPos;
@@ -49,7 +51,7 @@ struct FlangerGroupState : public EffectState {
 class FlangerEffect : public EffectProcessorImpl<FlangerGroupState> {
   public:
     FlangerEffect() = default;
-    virtual ~FlangerEffect();
+    ~FlangerEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/graphiceqeffect.cpp

@@ -131,9 +131,6 @@ void GraphicEQEffect::loadEngineEffectParameters(
     m_pPotHigh = parameters.value("high");
 }
 
-GraphicEQEffect::~GraphicEQEffect() {
-}
-
 void GraphicEQEffect::processChannel(
         GraphicEQEffectGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/graphiceqeffect.h

@@ -15,7 +15,7 @@
 class GraphicEQEffectGroupState : public EffectState {
   public:
     GraphicEQEffectGroupState(const mixxx::EngineParameters& engineParameters);
-    virtual ~GraphicEQEffectGroupState();
+    ~GraphicEQEffectGroupState() override;
 
     void setFilters(int sampleRate);
 
@@ -32,7 +32,7 @@ class GraphicEQEffectGroupState : public EffectState {
 class GraphicEQEffect : public EffectProcessorImpl<GraphicEQEffectGroupState> {
   public:
     GraphicEQEffect() = default;
-    virtual ~GraphicEQEffect();
+    ~GraphicEQEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/linkwitzriley8eqeffect.h

@@ -15,7 +15,7 @@
 class LinkwitzRiley8EQEffectGroupState : public EffectState {
   public:
     LinkwitzRiley8EQEffectGroupState(const mixxx::EngineParameters& engineParameters);
-    virtual ~LinkwitzRiley8EQEffectGroupState();
+    ~LinkwitzRiley8EQEffectGroupState() override;
 
     void setFilters(int sampleRate, int lowFreq, int highFreq);
 
@@ -40,7 +40,7 @@ class LinkwitzRiley8EQEffectGroupState : public EffectState {
 class LinkwitzRiley8EQEffect : public EffectProcessorImpl<LinkwitzRiley8EQEffectGroupState> {
   public:
     LinkwitzRiley8EQEffect();
-    virtual ~LinkwitzRiley8EQEffect();
+    ~LinkwitzRiley8EQEffect() override;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/loudnesscontoureffect.cpp

@@ -93,9 +93,6 @@ void LoudnessContourEffect::loadEngineEffectParameters(
     m_pUseGain = parameters.value("useGain");
 }
 
-LoudnessContourEffect::~LoudnessContourEffect() {
-}
-
 void LoudnessContourEffect::processChannel(
         LoudnessContourEffectGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/loudnesscontoureffect.h

@@ -14,7 +14,7 @@
 class LoudnessContourEffectGroupState final : public EffectState {
   public:
     LoudnessContourEffectGroupState(const mixxx::EngineParameters& engineParameters);
-    ~LoudnessContourEffectGroupState();
+    ~LoudnessContourEffectGroupState() override;
 
     void setFilters(int sampleRate, double gain);
 
@@ -33,7 +33,7 @@ class LoudnessContourEffect
         : public EffectProcessorImpl<LoudnessContourEffectGroupState> {
   public:
     LoudnessContourEffect() = default;
-    ~LoudnessContourEffect() override;
+    ~LoudnessContourEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/metronomeeffect.cpp

@@ -51,9 +51,6 @@ void MetronomeEffect::loadEngineEffectParameters(
     m_pSyncParameter = parameters.value("sync");
 }
 
-MetronomeEffect::~MetronomeEffect() {
-}
-
 void MetronomeEffect::processChannel(
         MetronomeGroupState* pGroupState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/metronomeeffect.h

@@ -17,16 +17,15 @@ class MetronomeGroupState final : public EffectState {
             : EffectState(engineParameters),
               m_framesSinceClickStart(0) {
     }
-    ~MetronomeGroupState() {
-    }
+    ~MetronomeGroupState() override = default;
 
     SINT m_framesSinceClickStart;
 };
 
 class MetronomeEffect : public EffectProcessorImpl<MetronomeGroupState> {
   public:
     MetronomeEffect() = default;
-    virtual ~MetronomeEffect();
+    ~MetronomeEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/moogladder4filtereffect.cpp

@@ -87,10 +87,6 @@ void MoogLadder4FilterEffect::loadEngineEffectParameters(
     m_pHPF = parameters.value("hpf");
 }
 
-MoogLadder4FilterEffect::~MoogLadder4FilterEffect() {
-    //qDebug() << debugString() << "destroyed";
-}
-
 void MoogLadder4FilterEffect::processChannel(
         MoogLadder4FilterGroupState* pState,
         const CSAMPLE* pInput,

src/effects/backends/builtin/moogladder4filtereffect.h

@@ -11,7 +11,8 @@
 class MoogLadder4FilterGroupState : public EffectState {
   public:
     MoogLadder4FilterGroupState(const mixxx::EngineParameters& engineParameters);
-    ~MoogLadder4FilterGroupState();
+    ~MoogLadder4FilterGroupState() override;
+
     void setFilters(int sampleRate, double lowFreq, double highFreq);
 
     CSAMPLE* m_pBuf;
@@ -27,7 +28,7 @@ class MoogLadder4FilterGroupState : public EffectState {
 class MoogLadder4FilterEffect : public EffectProcessorImpl<MoogLadder4FilterGroupState> {
   public:
     MoogLadder4FilterEffect() = default;
-    virtual ~MoogLadder4FilterEffect();
+    ~MoogLadder4FilterEffect() override = default;
 
     static QString getId();
     static EffectManifestPointer getManifest();

src/effects/backends/builtin/parametriceqeffect.cpp

@@ -136,9 +136,6 @@ void ParametricEQEffect::loadEngineEffectParameters(
     m_pPotCenter.append(parameters.value("center2"));
 }
 
-ParametricEQEffect::~ParametricEQEffect() {
-}
-
 void ParametricEQEffect::processChannel(
         ParametricEQEffectGroupState* pState,
         const CSAMPLE* pInput,