Glitch stutter built-in effect

[pcktm]

I wanted to share my progress on the effect I've been working on, as discussed on Zulip. I've managed to implement the basic functionality that I was going for, and I'm hoping to get some feedback on it. One thing to note is that the timing code I'm using is borrowed directly from the Echo effect, and while it seems to work, I'm definitely open to suggestions on alternatives! Please have a look and let me know what you think.

[JoergAtGithub]

Welcome and thanks for developing this effect! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

[pcktm]

Thanks, I've signed the agreement.

[JoergAtGithub]

It's recommended to install the pre-commit framework for automatic code checking: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking

[daschuer]

I have just tested it and it is a great fun, especially when vocals are involved.
Congratulations.

Unfortunately we have a pending issue, that new effects are hidden by default.

[ronso0]

Unfortunately we have a pending issue, that new effects are hidden by default.

Is there already an issue for that?

[daschuer]

I have also found none. Here it is: #11343

[pcktm]

I have scaled the timing to be more natural, with no glitch on knob at 0 and with infinite stretch on knob maxed out.

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[pcktm]

One thing that I've noticed that can be problematic, and is quite unexpected from a UX point of view, is that the buffer keeps repeating after the track has been paused. It is fairly obvious why this is the case, but is there any way to do anything about it?

[ferranpujolcamins]

One thing that I've noticed that can be problematic, and is quite unexpected from a UX point of view, is that the buffer keeps repeating after the track has been paused. It is fairly obvious why this is the case, but is there any way to do anything about it?

Yeah I've noticed this. Another similar issue is that when the delay knob is at high values you cannot smoothly fade out the track with the fader, since the effects are post-fader.

This is a bigger and more general issue with sampling effects. I'd prefer to merge this PR as is and think of a solution later. At the end, the user can fade the effect away with the effect unit dry/wet knob. It's not super intuitive, but if you think about it, is what's logical given effects are post-fader.

[Swiftb0y]

Thank you for your Pull request. Please understand that in order for us to be able to merge this, your contribution need to follow our style guide. Most of the required changes can be made automatically by use of pre-commit. Please set up pre-commit and make sure to manually apply the required changes using pre-commit run --from-ref main --to-ref HEAD. Thank you very much.

[pcktm]

Sure, last commit passed code style check already.

[ferranpujolcamins]

I've requested a couple more changes. Besides that LGTM. So from my side it's ready to merge after these last changes are implemented.

[pcktm]

Thanks a lot for the review and suggestions, can't wait to seeing this effect in a future release!

[ferranpujolcamins]

LGTM

[Swiftb0y]

Great. feel free to go ahead and merge 👍

[ferranpujolcamins]

@pcktm congrats on your first Mixxx contribution 🎉

I've thought about a couple possible next steps to make the effect even nicer, if you are up to:

• Make the buffer length editable with a parameter. I'd be curious how the effect sounds with longer repeat windows, kind of a beat repeater I guess.
• I believe the sound quality can be improved by crossfading a bit the buffers.