Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main EQ: properly restore parameters + also save 'no effect' to config #11271

Closed
wants to merge 2 commits into from
Closed

main EQ: properly restore parameters + also save 'no effect' to config #11271

wants to merge 2 commits into from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 13, 2023 •
edited
Loading

  • the empty Main EQ --- wasn't saved to config, so the previous valid effect was restored on next start unnoticed
  • Main EQ parameters were not restored because the loaded parameters were overwritten with default values during initial GUI setup, regression introduced by DlgPrefEQ: fix loading/saving main EQ parameters #4884

@github-actions github-actions bot added the ui label Feb 13, 2023
@ronso0 ronso0 mentioned this pull request Feb 13, 2023
Merged
@ronso0 ronso0 added the bug label Feb 19, 2023
@github-actions github-actions bot added the ui label Feb 24, 2023
@ronso0 ronso0 changed the title main EQ: also save 'no effect' to config main EQ: proeprly restore parameters + also save 'no effect' to config Feb 24, 2023
@ronso0 ronso0 modified the milestones: 2.4, 2.4.0 Feb 24, 2023
@ronso0 ronso0 changed the title main EQ: proeprly restore parameters + also save 'no effect' to config main EQ: propeprly restore parameters + also save 'no effect' to config Feb 24, 2023
@ronso0
Copy link
Member Author

ronso0 commented Feb 24, 2023

FYI I didn't optimize the existing code, I just moved the main EQ widget setup to a separate method and move a connect() a few lines down so the initial GUI setup doesn't trigger the reload slot.

@ronso0 ronso0 changed the title main EQ: propeprly restore parameters + also save 'no effect' to config main EQ: properply restore parameters + also save 'no effect' to config Mar 23, 2023
@ronso0 ronso0 changed the title main EQ: properply restore parameters + also save 'no effect' to config main EQ: properly restore parameters + also save 'no effect' to config Mar 24, 2023
@ronso0 ronso0 mentioned this pull request May 1, 2023
Merged
@ronso0 ronso0 marked this pull request as draft May 8, 2023 10:57
@ronso0
Copy link
Member Author

ronso0 commented May 8, 2023 •
edited
Loading

Superseded by #11527
Though, if no one wants to test/review that, this PR could be used as quick fix.

@ronso0 ronso0 closed this Jul 3, 2023
@ronso0 ronso0 deleted the main-eq-cleared branch July 3, 2023 07:36
@ronso0 ronso0 mentioned this pull request Aug 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug eq preferences regression ui
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ronso0