Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): windows codesign #11220

Merged
merged 2 commits into from
Jan 26, 2023
Merged

fix(build): windows codesign #11220

merged 2 commits into from
Jan 26, 2023

Conversation

Swiftb0y
Copy link
Member

@github-actions github-actions bot added the build label Jan 26, 2023
@daschuer
Copy link
Member

Thank you. Do we also want to backport:
#4825
?

@Swiftb0y
feat(build): timestamp signed file built via CMake
d86a753 
Previously only builds generated by our github actions CI
were timestamped.
@Swiftb0y
Copy link
Member Author

Good idea, done.

@daschuer
Copy link
Member

Thank you for the fast fix!

daschuer
daschuer approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 3e394fb into 2.3 Jan 26, 2023
@daschuer daschuer deleted the signtool_sha256_2.3 branch January 26, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swiftb0y @daschuer