Move connection to setEffectParameterSlot() to avoid double connection #11034
Conversation
| @@ -35,6 +35,14 @@ void WEffectParameterNameBase::setEffectParameterSlot( | |||
| &EffectParameterSlotBase::updated, | |||
| this, | |||
| &WEffectParameterNameBase::parameterUpdated); | |||
| if (qobject_cast<EffectKnobParameterSlot*>(m_pParameterSlot.data())) { | |||
There was a problem hiding this comment.
Why is this preferred over
if (m_pParameterSlot->parameterType() == EffectParameterType::Knob)
and use data() twice?
There was a problem hiding this comment.
data() has no cost because it is an inline function just returning the pointer.
https://github.com/qt/qtbase/blob/067b53864112c084587fa9a507eb4bde3d50a6e1/src/corelib/tools/qsharedpointer_impl.h#L271
I have decided to use the qobject_cast, because it makes it obvious that the result will not change during the lifetime of
m_pParameterSlot and the connection in this place is sufficient. Does this work for you?
|
Btw for both the previous and this connection the value is shown for Meta-linked parameters when the effect is changed (Meta-knob update I guess). Dunno if users will find this confusing. Probably not if we stick to .8 seconds. |
|
I'll take a closer look tomorrow to understand when exactly those slots are called. |
|
okay, got it:
LGTM, thank you! |
This is follow up to #11032.
Unfortunately I realized this issue not before merge.