Reloop Mixage MIDI mappings

[HorstBaerbel]

Redoing pull request. MIDI mappings for the Reloop Mixage DJ controller. Corresponding manual pull request is #516.

[HorstBaerbel]

No newline at the end of the file - oh, come on...

[ronso0]

No newline at the end of the file - oh, come on...

You may squash fixup commits as long as no one started reviewing the changes.
Or we squash when merging, after all issues and review comments are resolved. No big deal for a mapping.

[JosepMaJAZ]

I had a quick look at the source (I don't own this controller) and it looks good.
A classic non-components mapping with some added functionality (browsing with wheel, beat moving and some effect functionality).

The only thing that cached my eye was the use of a timer to update the vumeters. While this solution is ok, Mixxx has a control trigger to update the vumeters, just like it does for button leds.
You can check several controllers about this functionality, but two of them with which I am familiar is Hercules DJ Console 4-mx (non-compoments) and Numark Mixtrack Platinum (components).

[HorstBaerbel]

I had a quick look at the source (I don't own this controller) and it looks good. A classic non-components mapping with some added functionality (browsing with wheel, beat moving and some effect functionality).

The only thing that cached my eye was the use of a timer to update the vumeters. While this solution is ok, Mixxx has a control trigger to update the vumeters, just like it does for button leds. You can check several controllers about this functionality, but two of them with which I am familiar is Hercules DJ Console 4-mx (non-compoments) and Numark Mixtrack Platinum (components).

Thanks for your review. I can take a look at the other solutions for updating the vumeters. Could you link to the related Mixxx docs / functions? I seem to have missed this in the docs when implementing...

[ronso0]

The script for the Hercules DJ Console 4-mx mapping:

mixxx/res/controllers/Hercules-DJ-Console-4-Mx-scripts.js

Line 331 in 403c009

engine.connectControl("[Channel" + i + "]", "VuMeter", "Hercules4Mx.onVuMeterDeck" + i);

[Swiftb0y]

fyi thats not a great example. Prefer this instead:

updateVUMetersTimer[0] = engine.makeConnection("[Channel1]", "VuMeter", function(val) {
        midi.sendShortMsg(0x90, 29, val * 7);
});

and then disconnect on shutdown:

updateVUMetersTimer[0].disconnect()

See the wiki on engine.makeConnection

[HorstBaerbel]

I had a quick look at the source (I don't own this controller) and it looks good. A classic non-components mapping with some added functionality (browsing with wheel, beat moving and some effect functionality).

The only thing that cached my eye was the use of a timer to update the vumeters. While this solution is ok, Mixxx has a control trigger to update the vumeters, just like it does for button leds. You can check several controllers about this functionality, but two of them with which I am familiar is Hercules DJ Console 4-mx (non-compoments) and Numark Mixtrack Platinum (components).

I've refactored the VU meter updates as suggested. Tell me when there's anything else...

[HorstBaerbel]

The mappings got removed from the 2.3.4 milestone. Could you queue them for the next? Is there anything else I can do to get this PR accepted? Manual page should be ok too. Tell me if it needs work...

[Swiftb0y]

Sorry, I have a couple review comments pending but didn't get around to finish the review yet. please give me a couple days and feel free to remind me in case I forget.

[Swiftb0y]

first couple of comments

[HorstBaerbel]

I am done with the updated mapping. The only remaining issue is the open comment. Feedback is appreciated.

[HorstBaerbel]

Integrated your suggestions and updated the docs. Also added master balance (there is no deck balance in Mixxx). Thanks for all the suggestions! Mapping is much improved, more logical and faithful to the original one (where possible) with some extra functionality.
The pipeline seems to have choked on my commit though...

[HorstBaerbel]

@Swiftb0y So... This was not included in any of the 2.3 releases afair, which I find a bit sad, and the final 2.3 is out the door. But well. @gqzomer (Gersom Zomer) has been working on some improvements and refactored the JS. We're thinking about adding this to the 2.4 version to hopefully get released. How would we go about this?

[HorstBaerbel]

We've improved the mapping in this PR #12296 for Mixxx 2.4. I'm closing this PR now.

[Swiftb0y]

Thank you. I'm sorry I couldn't find the energy to look at this for now.