Numark DJ2Go2: Fix inverted tempo fader #10852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the inverted tempo fader moving issue. Part of issue mixxxdj#10586 (lp1948596).
doteya
commented
Sep 1, 2022
| @@ -94,7 +94,8 @@ DJ2GO2Touch.Deck = function(deckNumbers, midiChannel) { | |||
| this.tempoFader = new components.Pot({ | |||
| group: "[Channel" + script.deckFromGroup(this.currentDeck) + "]", | |||
| midi: [0xB0 + midiChannel, 0x09], | |||
| key: "rate" | |||
| key: "rate", | |||
| invert: true | |||
There was a problem hiding this comment.
DJ2GO2/DJ2GO2 Touch Tempo Fader sends MIDI Message,
Deck1 0xB0 0x09 value
Deck2 0xB1 0x09 value
value:
Top (Back-side) 0x00
Centre 0x40
Bottom (Front-side) 0x7F
This will be inverted from many other controllers.
There was a problem hiding this comment.
Makes sense. I encounter similar behavior on an unmapped Numark controller that I have laying around. I wonder why this was not discovered by @fjordstrom
Swiftb0y
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inverted tempo fader moving issue.
Part of issue #10586 (lp1948596).