Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog 2.3 #10851

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Changelog 2.3 #10851

merged 2 commits into from
Sep 1, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 31, 2022

forgot to add a changelog item for #10821

@daschuer
Copy link
Member

daschuer commented Sep 1, 2022

Thank you for taking care. You did not "forget" something. Our current workflow includes to collect changes and add the change-log commit later when something has stacked up.

I am afraid the first commit is failing. Not a big issue here, just a note for next time: amend the changes of the per-commit hook.

@daschuer daschuer merged commit 80b9753 into mixxxdj:2.3 Sep 1, 2022
@ronso0
Copy link
Member Author

ronso0 commented Sep 1, 2022

well, I forgot to add the changelog label, so I opened the PR right away.

One strange thing with that pre-commit hook:
I ammended the changes, then the pre-push hook changed the date again -- which I didn't ammend obviously.

@ronso0 ronso0 deleted the changelog-2.3 branch September 21, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants