fixes in common-controller-scripts.js #1072
Conversation
| // disable on note-off or zero value note/cc | ||
| engine.brake(parseInt(group.substring(8,9)), ((status & 0xF0) != 0x80 && value > 0)); | ||
| // calculate current playback speed | ||
| var currentRate = engine.getValue(group,"bpm") / engine.getValue(group,"file_bpm"); |
There was a problem hiding this comment.
Would engine.getValue(group, "rate"); work?
There was a problem hiding this comment.
In the wiki I see that 'rate' ranges from -1...0..1 (which I read as "0 = normal speed") while in brake() 'rate' '1' means normal speed, -10 would be 10x backwards
So I guess no. And I was to lazy to even think about the conversion.. ;)
But the identical naming is irritating, though. Maybe in brake() 'rate' should be 'speed'?
There was a problem hiding this comment.
Okay, I was asking in case it would be easier to just get the rate value without having to manipulate it at all. I'm okay with the naming as is.
|
Thanks for fixing these. :) |
| @@ -44,6 +44,7 @@ TerminalMix.init = function (id,debug) { | |||
| engine.softTakeover("[Channel"+i+"]","filterHigh",true); | |||
| engine.softTakeover("[Channel"+i+"]","filterMid",true); | |||
| engine.softTakeover("[Channel"+i+"]","filterLow",true); | |||
| engine.softTakeover("[Channel"+i+"]","rate",true); | |||
|
Okay, LGTM. If you have any more changes for the Terminal Mix mapping, make a separate pull request with a new branch for those. |
|
Thank you very much :-) |
|
Cool! |
This is my first fix on github -woohoo!- so please tell me when I'm doing something...not right.
In the first fix I just corrected the use of 'numberOfBeats' for loopMove function.
The second one is about script.brake() and considers the actual playback speed:
Until now, a pitched track would jump to 100% speed, then slow down
see https://bugs.launchpad.net/mixxx/+bug/1571442