Hercules P32 mapping and Controls JS library #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contains initial commit of JS library as well, which is used for the bottom row of buttons and the PFL button mapped: browse encoder, load buttons, loop size/tempo encoder, loop size LED displays, filter/loop move encoder, EQ knobs, PFL buttons, volume faders, crossfader, sync, cue, play, keylock, quantize TODO: make deck toggling work, shift buttons, record button, slip button, pad grids, effects knobs, and effects buttons
for now, deck toggling can be tested by uncommenting line in Deck.tempoReset()
same encoder controls loop size, loop activation, and loop moving
…to toggle split cue mode
… 0 to turn off buttons on screen
forgot to add this to a previous commit
… to 0 User reported this can cause Mixxx to hang on the forum thread: http://mixxx.org/forums/viewtopic.php?f=7&t=8132
Instead, give each Control has its own group property
Press to select beat jumping size. Using a stepped encoder for the filter did not sound that great and now that the effects are mapped, the filter effect can be used in an effect rack with smooth knobs.
These methods can be useful to override with functions that don't necessarily deal with sending out MIDI messages.
…hem helpful for managing soft takeover
…fectOnGroupButton to enableEffectUnitOnDeckButton
|
Please add lodash.mixxx.js to windows uninstaller. |
now that those switches are persistent
…th parameters showing
Be-ing
force-pushed
the
hercules_p32_mapping_for_2.1
branch
from
51b80bf to
73402bf
Compare
Merged
as per discussion on PR mixxxdj#1062
and improve EffectUnit documentation
|
I think the EffectUnit ControlContainer is a good example of how this library can be used to manage the complex interaction of multiple layers in various conditions. |
plus miscellaneous fixes for the Hercules P32 mapping
rryan
reviewed
Jan 20, 2017
| <name>Hercules P32 DJ</name> | ||
| <author>Be</author> | ||
| <description>4-deck mapping for Hercules P32 controller</description> | ||
| <forums>http://mixxx.org/forums/viewtopic.php?f=7&t=8132</forums> |
There was a problem hiding this comment.
Want to add link to the wiki page for it?
|
thanks! |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains both a mapping for the Hercules P32 controller and a new JavaScript library to make mapping development easier. I'd like feedback on both. Documentation for the P32 functionality is on
the wiki. I have started documenting the library inline with the code. Later, I'll move the library documentation to the wiki, but I think it should stay inline while this PR is being reviewed. Please ask questions about the code so I know what to document. :) Look at the P32-specific code for examples of how to use the library. Almost all functionality in the P32 mapping uses the library, except in some cases where it would be overcomplicated. If you have ideas of how to make the library more generally useful for different controllers, please comment.
The library is everything in Hercules-P32-scripts.js above
var P32 = {};. For now, I think it should stay there. If anyone else wants to use it, feel free to copy and paste it into your own mapping. This will allow for rapid changes that don't have to maintain backwards compatibility. Perhaps after several people have used it for different controllers, it may make sense to move it to a separate shared JavaScript file.The library depends on two functions from Lodash, merge and assign. I made a custom build of Lodash including only those two functions. If you want to use the library yourself, you'll have to include the new lodash.mixxx.js file with your XML file.
The library is not compatible with Mixxx 2.0 because it takes advantage of functionality introduced by PR #919. I have made a Mixxx 2.0 compatible version of the P32 mapping that is functionally identical to this on a separate branch.