Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slip mode wrong behavior if deck is playing a Loop #6993

Closed
mixxxbot opened this issue Aug 22, 2022 · 3 comments
Closed

slip mode wrong behavior if deck is playing a Loop #6993

mixxxbot opened this issue Aug 22, 2022 · 3 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: enrydj
Date: 2013-04-21T08:37:31Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1171095
Tags: looping, slip


build r3818 Ubuntu 12.04

If Spinning Vinyl panel right mouse button feature is enabled while the deck is playing a loop, when right mouse button is released tracks continues playing from a time position that does not take into account that loop was enabled. Loop is disabled. Is that wanted?

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2013-04-30T18:59:31Z


per our IRC discussion, this is the correct behavior, especially for rolling loops.

But I could imagine, if a loop already existed at the time loop mode was enabled, maybe the loop should be preserved? That's an interesting use-case.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2013-04-30T19:12:21Z


Hm, yea I agree that if the loop already existed when the rolling-whatever
starts then the played audio and jump should take the loop into account.
Implementation-wise this is super complicated though so it will be a lot of
effort to fix.

On Tue, Apr 30, 2013 at 2:59 PM, Owen Williams wrote:

per our IRC discussion, this is the correct behavior, especially for
rolling loops.

But I could imagine, if a loop already existed at the time loop mode
was enabled, maybe the loop should be preserved? That's an interesting
use-case.

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1171095

Title:
Spinning Vinyl right mouse button wrong behavior if deck is playing a
Loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1171095/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-12-06T20:51:25Z


#1207 changed right clicking WSpinny to show the cover art menu instead of enabling slip mode.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@daschuer daschuer added this to the 2.4.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants