Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slip mode handles loops not correct #11844

Closed
JoergAtGithub opened this issue Aug 20, 2023 · 2 comments
Closed

Slip mode handles loops not correct #11844

JoergAtGithub opened this issue Aug 20, 2023 · 2 comments

Comments

@JoergAtGithub
Copy link
Member

Bug Description

  • play a track
  • engage slip mode
  • set and enable a new loop
  • stop the loop after some iterations
  • disable slip mode

=> Play position should jump to the position where the track would be without the loop - this is the case with 2.3 but not with 2.4

see discussion at:
https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/Slip.20mode/near/386262097

Version

2.4beta

OS

Windows 11

@ronso0
Copy link
Member

ronso0 commented Aug 21, 2023

I'll take a look asap.
If I can't fix it in time we need to roll back the last two commits of #11435, i.e. restore 2.3 behaviour at the cost of not fixing #6993

@ronso0
Copy link
Member

ronso0 commented Aug 21, 2023

Fixed by #11848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants