Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the "Reset BPM" in the "Adjust BPM" submenu only restore BPM to before any new user change, not fully clear the BPM and beatgrid? #12774

Closed
mxmilkiib opened this issue Feb 9, 2024 · 6 comments · Fixed by #12954

Comments

@mxmilkiib
Copy link
Contributor

Feature Description

It would be nice to reset an altered BPM to the number that it was before (on load to the deck I guess), rather than clear the beatgrid, which then requires the extra step of Analysing the track again to get back to where things were.

There's already "BPM and beatgrid" in the "Reset" submenu.

A new phrasing to differentiate? Personally I think "Reset" would be turning it back to the prior number, where as something like "Clear" would be a clearer title for the "Reset" submenu, but if the meaning of "Reset" stays the same, then the "Adjust BPM" reset entry could be maybe "Restore BPM" instead?

@ronso0
Copy link
Member

ronso0 commented Feb 9, 2024

Hmm, IIUC that would require to store the previous beats (BPM + beat map/grid) per track, at least for the current session.

@ronso0
Copy link
Member

ronso0 commented Feb 15, 2024

I agree with the unclear phrasing Reset / Clear.

Never the less, in order to implement Reset (revert to track's database state from when Mixxx was started) it had to keep a dupe of the entire db or just modified tracks. Not sure if that is feasible, effort (implementation + maintenance) vs. benefit

@mxmilkiib
Copy link
Contributor Author

Arguably a dupe of #10138

@ronso0
Copy link
Member

ronso0 commented Mar 12, 2024

"Clear" would be a clearer title for the "Reset" submenu

Do you mind opening a PR?
The sooner the better as it increases the probability translators adjust the translations.

@ronso0
Copy link
Member

ronso0 commented Mar 12, 2024

It would be nice to reset an altered BPM to the number that it was before (on load to the deck I guess)

Fixed by 12954.
Applies to all BPM/beats changes (decks and library track menu).

on load to the deck I guess

This is more elaborate than simply tracking BPM/beats changes in the track object itself.
Also when the track is (re)analyzed the "on load to the deck" state might be 0.
I propose to go with the general implementation #12954.
Please test!

@ronso0
Copy link
Member

ronso0 commented May 14, 2024

Please note that #12954 only adds the control, no skin implementation, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants