-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have the "Reset BPM" in the "Adjust BPM" submenu only restore BPM to before any new user change, not fully clear the BPM and beatgrid? #12774
Comments
Hmm, IIUC that would require to store the previous beats (BPM + beat map/grid) per track, at least for the current session. |
I agree with the unclear phrasing Reset / Clear. Never the less, in order to implement Reset (revert to track's database state from when Mixxx was started) it had to keep a dupe of the entire db or just modified tracks. Not sure if that is feasible, effort (implementation + maintenance) vs. benefit |
Arguably a dupe of #10138 |
Do you mind opening a PR? |
Fixed by 12954.
This is more elaborate than simply tracking BPM/beats changes in the track object itself. |
Please note that #12954 only adds the control, no skin implementation, yet. |
Feature Description
It would be nice to reset an altered BPM to the number that it was before (on load to the deck I guess), rather than clear the beatgrid, which then requires the extra step of Analysing the track again to get back to where things were.
There's already "BPM and beatgrid" in the "Reset" submenu.
A new phrasing to differentiate? Personally I think "Reset" would be turning it back to the prior number, where as something like "Clear" would be a clearer title for the "Reset" submenu, but if the meaning of "Reset" stays the same, then the "Adjust BPM" reset entry could be maybe "Restore BPM" instead?
The text was updated successfully, but these errors were encountered: