-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change BPM: fraction bpm-change result preview #10128
Comments
Commented by: mxmilkiib Not here, though I did recently make a specific UI suggestion for "Round scanned BPM values" #9464 I'm more meaning that, if I want to play a track, but the bpm is wrong, (and assuming Mixxx bpm detection is only off by a ratio) I think there is a middle UX possibility between a) having to work my brain about what bpm change ratio I should be applying (and maybe how to reverse/reset/fix if I get it wrong) and b) hoping that I can precisely enough tap out a "bpm" that'll get me to the middle/end of the track. A sort of relate-taps-algo-bpm-with-feature-detection-algo-detected-bpm-to-fix-bpm thing. |
Commented by: ronso0 okay, now I understand. I see two ways to fix the situation:
( detected BPM ) I think we should go with the BPM preview ;) From the library table, this would work for single tracks only though. |
Commented by: mxmilkiib
Haha, you make a very good point :)
Sure, it appears a fair balance for humans. |
Commented by: mxmilkiib Having thought about it and tried some more, the next logical question after "what if you don't understand the fraction?" is "what if you don't understand the bpm?", as in, the user doesn't know what that bpm number "means". So, to channel some Bret Victor, would it be too much to have the lines in the change-previews submenu finish visually with a dot that flashes at that bpm? |
Commented by: daschuer How about just add a checkbox |
Commented by: ronso0 "what if you don't understand the bpm?" Is it not sufficient to see/hear the relation of vertical strokes on the waveform to peaks in the waveform shape? "would it be too much to have the lines in the change-previews submenu finish visually with a dot that flashes at that bpm?" Let's go with the BPM number preview first. |
My original proposal and answers on this one were a bit wordy and confusing. So, the proposal; add the calculated BPM as text to the end of each option in submenu. The Search Related Tracks submenu already has dynamic content depending on the selected track. E.g. for a 93.3 BPM track, the submenu would show;
which makes things a lot clearer. Or maybe as the same format as the Search Related ones I guess;
See also: #12579 |
Thank you for adding the resultant tempos to the Adjust BPM menu, that is and will be a great help! And also for resolving #12579 at the same time! From a quick scan, there were three proposals, rephrased/summed up here;
Maybe the other two should be spilt out just to keep 'one issue to one feature'? My 2p regarding the worth of each; I understand better now the worry about the probable complexity 'problem' with "flashing preview in the menu would be better if the user is actually playing the track" and "the preview should start flashing in relation to the track start or primary cue" (I think that's a more logical approach than "relating it to the true downbeats", which is a paradox!) Also, if the track bpm is going to be snapped to the "fraction of the detected that it's nearest the tapping" (which could be initiated by holding down ctrl when clicking"TAP"(?)), it's not intuitively obvious that the result is securely correct; if comprehending the waveform and beatgrid of the new tempo is still hard for some folk/cases, a flash of the new tempo is the method I think would round that off. Adding a(n optional) flash of the tempo to skins is #5454/#5852/#12128, so my overall take is that that issue/feature should be the priority; personally I think it wins in terms of usefulness, it's simpler than the other two here. P.S. I just added another BPM-alteration related FR issue, #12774 |
Reported by: mxmilkiib
Date: 2020-09-24T22:43:00Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1897186
Tags: bpm, usability
So far, it appears to me that if Mixxx gets the tempo incorrect, it gets it incorrect at some fraction of the actual bpm.
This is why the 'Change BPM' submenu has entries to adjust the number by some fraction.
But I would suggest that many cannot think in these terms and could compound the problem, something stressful whilst trying to mix.
My suggestion would be an option in the 'Change BPM' submenu for 'Tap to detect fraction change' or something; because whilst a tap tempo might (probably won't imho) give the correct bpm, it will (most likely) give a bpm near one of the resultant bpms from the fraction change options that are available, thus alleviating that choice from the user.
The text was updated successfully, but these errors were encountered: