New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Installing qml_formatter fails with "Executable `rustup` not found" #11386

Closed

JoergAtGithub opened this issue Mar 18, 2023 · 3 comments

Labels

bug

Member

JoergAtGithub commented Mar 18, 2023

Bug Description

All recent CI builds of various PRs for 2.4/Main fail:

for example: https://github.com/mixxxdj/mixxx/actions/runs/4455587774/jobs/7825486519?pr=10989

Version

2.4.0/Main

OS

Pre-Commit

JoergAtGithub added the bug label

JoergAtGithub mentioned this issue

Tooltip Text changed from Interface to Decks #11387

Merged

daschuer mentioned this issue

Key refactoring #11301

Merged

Member

daschuer commented Mar 19, 2023

It might be caused by an pre-commit update.
This ins one of the last working runs:
https://github.com/mixxxdj/mixxx/actions/runs/4448394360/jobs/7811151308
Downloading pre_commit-3.1.1-py2.py3-none-any.whl (202 kB)

This is a failing one:
https://github.com/mixxxdj/mixxx/actions/runs/4451827087/jobs/7824682752
Downloading pre_commit-3.2.0-py2.py3-none-any.whl (202 kB)

Member

daschuer commented Mar 19, 2023

There is no easy way to pin the pre-commit version:
https://github.com/pre-commit/action/blob/main/action.yml

I think it is best to temporary disable the almost not used qml_formatter until upstream has a fix.

daschuer mentioned this issue

don't set CARGO_HOME in rust pre-commit/pre-commit#2820

Merged

daschuer added a commit to daschuer/mixxx that referenced this issue


          Disable qml-formatter unit mixxxdj#11386 is fixed

77b9944

daschuer added a commit to daschuer/mixxx that referenced this issue


          Disable qml-formatter unit mixxxdj#11386 is fixed

39a5b35

daschuer mentioned this issue

No longer trigger unneccessary searches om left and right cursor keys #11289

Merged

Swiftb0y added a commit that referenced this issue


          Merge pull request #11388 from daschuer/gh11386

146f0bb

Disable qml-formatter until #11386 is fixed

daschuer mentioned this issue

Upload pre-commit.log in case of failure #11396

Merged

Member

daschuer commented Mar 20, 2023

This is the upstream bug: pre-commit/pre-commit#2823

Swiftb0y added a commit to Swiftb0y/mixxx that referenced this issue


          Revert "Disable qml-formatter unit mixxxdj#11386 is fixed"

85523f4

This reverts commit 39a5b35.

JoergAtGithub added a commit that referenced this issue


          Merge pull request #11414 from Swiftb0y/chore/reenable-qml-formatter

e1a8fe6

Revert "Disable qml-formatter unit #11386 is fixed"

JoergAtGithub closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment