Effect chain preset menu: show preset effects in tooltip

mixxxdj · Aug 31, 2023 · f2b3f24 · f2b3f24
1 parent 0b67e17
commit f2b3f24
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/src/widget/weffectchainpresetbutton.cpp b/src/widget/weffectchainpresetbutton.cpp
@@ -43,13 +43,15 @@ void WEffectChainPresetButton::setup(const QDomNode& node, const SkinContext& co
                 this,
                 &WEffectChainPresetButton::populateMenu);
     }
+    m_pMenu->setToolTipsVisible(true);
     populateMenu();
 }
 
 void WEffectChainPresetButton::populateMenu() {
     m_pMenu->clear();
 
     // Chain preset items
+    const auto bem = m_pEffectsManager->getBackendManager();
     bool presetIsReadOnly = true;
     for (const auto& pChainPreset : m_pChainPresetManager->getPresetsSorted()) {
         QString title = pChainPreset->name();
@@ -58,9 +60,22 @@ void WEffectChainPresetButton::populateMenu() {
                     QChar(' ') + title;
             presetIsReadOnly = pChainPreset->isReadOnly();
         }
-        m_pMenu->addAction(title, this, [this, pChainPreset]() {
-            m_pChain->loadChainPreset(pChainPreset);
-        });
+        QStringList tooltip;
+        tooltip.append(QStringLiteral("<b>") + pChainPreset->name() + QStringLiteral("</b>"));
+        for (const auto pEffectPreset : pChainPreset->effectPresets()) {
+            if (!pEffectPreset->isEmpty()) {
+                tooltip.append(bem->getDisplayNameForEffectPreset(pEffectPreset));
+            }
+        }
+        QAction* pAction(new QAction(title, this));
+        connect(pAction,
+                &QAction::triggered,
+                this,
+                [this, pChainPreset]() {
+                    m_pChain->loadChainPreset(pChainPreset);
+                });
+        pAction->setToolTip(tooltip.join("<br/>"));
+        m_pMenu->addAction(pAction);
     }
     m_pMenu->addSeparator();
     // This prevents showing the Update button for the empty '---' preset, in case