TODOs Library sidebar

mixxxdj · Jan 30, 2023 · b607fb8 · b607fb8
1 parent e6c4adf
commit b607fb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/library/itunes/itunesfeature.cpp b/src/library/itunes/itunesfeature.cpp
@@ -152,6 +152,7 @@ QVariant ITunesFeature::title() {
 }
 
 void ITunesFeature::bindSidebarWidget(WLibrarySidebar* pSidebarWidget) {
+    // TODO(XXX) Isn't this redundant?
     // store the sidebar widget pointer for later use in onRightClick()
     m_pSidebarWidget = pSidebarWidget;
     // send it to BaseExternalLibraryFeature for onRightClickChild()

diff --git a/src/library/trackset/crate/cratefeature.cpp b/src/library/trackset/crate/cratefeature.cpp
@@ -577,6 +577,8 @@ QModelIndex CrateFeature::rebuildChildModel(CrateId selectedCrateId) {
     // Update rendering of crates depending on the currently selected track
     slotTrackSelected(m_selectedTrackId);
 
+    // actually this filter is obsolete because TreeItemModel::index returns QModelIndex()
+    // if it can't create the new index for whatever reason
     if (selectedRow >= 0) {
         return m_pSidebarModel->index(selectedRow, 0);
     } else {