Improve code readability

Co-authored-by: JoergAtGithub <[email protected]>
mixxxdj · Nov 13, 2023 · b5cccbb · b5cccbb
1 parent e19da2c
commit b5cccbb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/library/basetracktablemodel.cpp b/src/library/basetracktablemodel.cpp
@@ -562,7 +562,8 @@ QVariant BaseTrackTableModel::composeCoverArtToolTipHtml(
             coverInfo,
             absoluteHeightOfCoverartToolTip);
     if (pixmap.isNull()) {
-        // Cache miss -> Request Cover via coverFound signal
+        // Cache miss -> Don't show a tooltip, refresh cache
+        // Height used for the width, in assumption that covers are squares
         CoverArtCache::requestUncachedCover(
                 this,
                 coverInfo,

diff --git a/src/library/coverartcache.cpp b/src/library/coverartcache.cpp
@@ -89,18 +89,19 @@ QPixmap CoverArtCache::getCachedCover(
     QString cacheKey = pixmapCacheKey(requestedCacheKey, desiredWidth);
 
     QPixmap pixmap;
-    if (QPixmapCache::find(cacheKey, &pixmap)) {
-        if (kLogger.traceEnabled()) {
-            kLogger.trace()
-                    << "requestCover cache hit"
-                    << coverInfo;
-        }
-    } else {
+    if (!QPixmapCache::find(cacheKey, &pixmap)) {
         if (kLogger.traceEnabled()) {
             kLogger.trace()
                     << "requestCover cache miss"
                     << coverInfo;
         }
+        return QPixmap();
+    }
+
+    if (kLogger.traceEnabled()) {
+        kLogger.trace()
+                << "requestCover cache hit"
+                << coverInfo;
     }
     return pixmap;
 }