Merge pull request #13997 from ronso0/s4mk3-quickfx-offset

(fix) Traktor Kontrol S4 Mk3: revert QuickEffect preset offset
mixxxdj · Dec 16, 2024 · a20384b · a20384b
2 parents 04c05ad + 5059c5d
commit a20384b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/res/controllers/Traktor-Kontrol-S4-MK3.js b/res/controllers/Traktor-Kontrol-S4-MK3.js
@@ -1262,7 +1262,7 @@ class FXSelect extends Button {
         if (this.mixer.firstPressedFxSelector !== null) {
             for (const deck of [1, 2, 3, 4]) {
                 const presetNumber = this.mixer.calculatePresetNumber();
-                engine.setValue(`[QuickEffectRack1_[Channel${deck}]]`, "loaded_chain_preset", presetNumber + 1);
+                engine.setValue(`[QuickEffectRack1_[Channel${deck}]]`, "loaded_chain_preset", presetNumber);
             }
         }
         if (this.mixer.firstPressedFxSelector === this.number) {
@@ -1296,7 +1296,7 @@ class QuickEffectButton extends Button {
         } else {
             const presetNumber = this.mixer.calculatePresetNumber();
             this.color = QuickEffectPresetColors[presetNumber - 1];
-            engine.setValue(this.group, "loaded_chain_preset", presetNumber + 1);
+            engine.setValue(this.group, "loaded_chain_preset", presetNumber);
             this.mixer.firstPressedFxSelector = null;
             this.mixer.secondPressedFxSelector = null;
             this.mixer.resetFxSelectorColors();
@@ -1317,7 +1317,7 @@ class QuickEffectButton extends Button {
         }
     }
     presetLoaded(presetNumber) {
-        this.color = QuickEffectPresetColors[presetNumber - 2];
+        this.color = QuickEffectPresetColors[presetNumber - 1];
         this.outConnections[1].trigger();
     }
     outConnect() {