Refactor setting check logic

mixxxdj · Sep 16, 2024 · 9aabb13 · 9aabb13
1 parent 4803dc1
commit 9aabb13
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/controllers/legacycontrollersettings.h b/src/controllers/legacycontrollersettings.h
@@ -259,16 +259,13 @@ class LegacyControllerNumberSetting
     /// and a strictly positive step, strictly less than max..
     /// @return true if valid
     bool valid() const override {
-        static constexpr bool typeSize = sizeof(long) == sizeof(int);
         return AbstractLegacyControllerSetting::valid() &&
                 m_defaultValue >= m_minValue && m_savedValue >= m_minValue &&
                 m_editedValue >= m_minValue && m_defaultValue <= m_maxValue &&
                 m_savedValue <= m_maxValue && m_editedValue <= m_maxValue &&
                 m_stepValue > 0 &&
-                (typeSize ||
-                        static_cast<long>(m_stepValue) <
-                                static_cast<long>(m_maxValue) -
-                                        static_cast<long>(m_minValue));
+                ((m_minValue <= 0 && m_minValue + m_stepValue <= m_maxValue) ||
+                        (m_maxValue >= 0 && m_maxValue - m_stepValue >= m_minValue));
     }
 
     static AbstractLegacyControllerSetting* createFrom(const QDomElement& element) {