DlgCoverArtFullSize: copy fetched cover by value

Co-authored-by: Daniel Schürmann <[email protected]>
mixxxdj · Nov 16, 2023 · 973d012 · 973d012
1 parent cd1e4e1
commit 973d012
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/library/dlgcoverartfullsize.cpp b/src/library/dlgcoverartfullsize.cpp
@@ -85,8 +85,8 @@ void DlgCoverArtFullSize::init(TrackPointer pTrack) {
     slotLoadTrack(pTrack);
 }
 
-void DlgCoverArtFullSize::initFetchedCoverArt(const QPixmap& pixmap) {
-    m_pixmap = pixmap;
+void DlgCoverArtFullSize::initFetchedCoverArt(QPixmap pixmap) {
+    m_pixmap = std::move(pixmap);
 
     // The real size will be calculated later by adjustImageAndDialogSize().
     resize(100, 100);

diff --git a/src/library/dlgcoverartfullsize.h b/src/library/dlgcoverartfullsize.h
@@ -24,7 +24,7 @@ class DlgCoverArtFullSize
     ~DlgCoverArtFullSize() override = default;
 
     void init(TrackPointer pTrack);
-    void initFetchedCoverArt(const QPixmap& fetchedCoverArtBytes);
+    void initFetchedCoverArt(QPixmap pixmap);
     void mousePressEvent(QMouseEvent* event) override;
     void mouseReleaseEvent(QMouseEvent* ) override;
     void mouseMoveEvent(QMouseEvent* ) override;