Preferences: only apply in slotApply()

mixxxdj · May 29, 2024 · 8bb022e · 8bb022e
1 parent db408f8
commit 8bb022e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/src/preferences/dialog/dlgprefcolors.cpp b/src/preferences/dialog/dlgprefcolors.cpp
@@ -161,7 +161,6 @@ void DlgPrefColors::slotResetToDefaults() {
             mixxx::PredefinedColorPalettes::kDefaultTrackColorPalette.size());
     comboBoxLoopDefaultColor->setCurrentIndex(
             mixxx::PredefinedColorPalettes::kDefaultTrackColorPalette.size() - 1);
-    slotApply();
 }
 
 // Apply and save any changes made in the dialog

diff --git a/src/preferences/dialog/dlgprefkey.cpp b/src/preferences/dialog/dlgprefkey.cpp
@@ -162,9 +162,7 @@ void DlgPrefKey::slotResetToDefaults() {
         radioNotationOpenKey->setChecked(true);
         notation_type = KeyUtils::KeyNotation::OpenKey;
     }
-    setNotation(notation_type);
-
-    slotUpdate();
+    setNotation(notation_type); // calls slotUpdate()
 }
 
 void DlgPrefKey::pluginSelected(int i) {

diff --git a/src/preferences/dialog/dlgprefmixer.cpp b/src/preferences/dialog/dlgprefmixer.cpp
@@ -470,7 +470,6 @@ void DlgPrefMixer::slotResetToDefaults() {
 
     setDefaultShelves();
     comboBoxMainEq->setCurrentIndex(0); // '---' no EQ
-    slotApply();
 }
 
 void DlgPrefMixer::slotEQEffectSelectionChanged(int effectIndex) {