controller disconnect: store an explicit list of connections

mixxxdj · Oct 23, 2021 · 7b595c0 · 7b595c0
1 parent 2c800c3
commit 7b595c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/controllers/dlgprefcontrollers.cpp b/src/controllers/dlgprefcontrollers.cpp
@@ -130,9 +130,10 @@ void DlgPrefControllers::rescanControllers() {
 }
 
 void DlgPrefControllers::destroyControllerWidgets() {
-    for (auto* pController : m_pControllerManager->getControllerList(false, true)) {
-        pController->disconnect(SIGNAL(&Controller::openChanged));
+    for (auto conn : m_controllerConnections) {
+        disconnect(conn);
     }
+    m_controllerConnections.clear();
     while (!m_controllerPages.isEmpty()) {
         DlgPrefController* pControllerDlg = m_controllerPages.takeLast();
         m_pDlgPreferences->removePageWidget(pControllerDlg);
@@ -174,11 +175,11 @@ void DlgPrefControllers::setupControllerWidgets() {
 
         m_controllerPages.append(pControllerDlg);
 
-        connect(pController,
+        m_controllerConnections.append(connect(pController,
                 &Controller::openChanged,
                 [this, pControllerDlg](bool bOpen) {
                     slotHighlightDevice(pControllerDlg, bOpen);
-                });
+                }));
 
         QTreeWidgetItem* pControllerTreeItem = new QTreeWidgetItem(
                 QTreeWidgetItem::Type);

diff --git a/src/controllers/dlgprefcontrollers.h b/src/controllers/dlgprefcontrollers.h
@@ -52,4 +52,5 @@ class DlgPrefControllers : public DlgPreferencePage, public Ui::DlgPrefControlle
     QTreeWidgetItem* m_pControllersRootItem;
     QList<DlgPrefController*> m_controllerPages;
     QList<QTreeWidgetItem*> m_controllerTreeItems;
+    QList<QMetaObject::Connection> m_controllerConnections;
 };