Skip to content

Commit

Permalink
Fix echo effect using left buffered samples for right channel.
Browse files Browse the repository at this point in the history
SB committed Jul 24, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent d01882a commit 686738d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/effects/builtin/echoeffect.cpp
Original file line number Diff line number Diff line change
@@ -221,7 +221,7 @@ void EchoEffect::processChannel(const ChannelHandle& handle, EchoGroupState* pGr
bufferedSampleLeft * feedback_ramped);
pGroupState->delay_buf[pGroupState->write_position + 1] = SampleUtil::clampSample(
pInput[i + 1] * send_ramped +
bufferedSampleLeft * feedback_ramped);
bufferedSampleRight * feedback_ramped);

// Pingpong the output. If the pingpong value is zero, all of the
// math below should result in a simple copy of delay buf to pOutput.

0 comments on commit 686738d

Please sign in to comment.