Skip to content

Commit

Permalink
change KeyChangeList from a QVector to a QList
Browse files Browse the repository at this point in the history
QVector and QList have been consolidated in Qt6. In Qt5,
QVector::iterator is a pointer type, so clang-tidy wants to use
auto* rather than auto. This is not an issue using QList instead;
simply using auto works.
  • Loading branch information
Be-ing committed Oct 13, 2021
1 parent ace02c5 commit 02d8f13
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/track/keyfactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Keys KeyFactory::makePreferredKeys(

if (version == KEY_MAP_VERSION) {
KeyMap key_map;
for (const auto* it = key_changes.constBegin();
for (auto it = key_changes.constBegin();
it != key_changes.constEnd();
++it) {
// Key position is in frames. Do not accept fractional frames.
Expand Down
4 changes: 2 additions & 2 deletions src/track/keys.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#pragma once

#include <QByteArray>
#include <QList>
#include <QPair>
#include <QVector>

#include "proto/keys.pb.h"

#define KEY_MAP_VERSION "KeyMap-1.0"

typedef QVector<QPair<mixxx::track::io::key::ChromaticKey, double> > KeyChangeList;
typedef QList<QPair<mixxx::track::io::key::ChromaticKey, double> > KeyChangeList;

class KeyFactory;

Expand Down

0 comments on commit 02d8f13

Please sign in to comment.