-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Numark Mixtrack Platinum FX #623
base: 2.4
Are you sure you want to change the base?
Conversation
evoixmr 2.4<2..4V2 Update numark_mixtrack_platinum_fx.rst
Just a quick note regrading the images: |
@ronso0 I updated all photos and scripts to use svg. I also deleted the png files. |
.. Credit to PopHippy for creating the original PDF file. | ||
|
||
Numark Mixtrack Platinum FX | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated header.
:alt: Numark Mixtrack Playinum FX (schematic view) | ||
:figclass: pretty-figures | ||
|
||
--------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--------------- | |
--------------- |
Please remove these lines. They prevent proper header rendering. Also some table rows are broken due to blank lines.
I suggest you check the preview and tweak until it looks as desired.
https://deploy-preview-623--mixxx-manual.netlify.app/hardware/controllers/numark_mixtrack_platinum_fx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The appearance is still broken, just check the preview.
FYI you may also build the html locally with make html
and double-check before pushing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the appearance. Can you recheck and make suggestion on which areas need to be improve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's loking good now. It were just the blank lines that enforced header formatting on each following line.
Thanks for the reminder @evoixmr
IIUC work on this mapping started while 2.3 was the stable version, and 2.4 now allows to load specific effect presets (ie. items at specific position in the preset list, not by effect uuid or something). |
Yes, the PR is ready. As far as he effects preset, is there a documentation that I can use to add preset? |
All effect / effect chain preset controls are documented here Loading specific Quick Effect presets can be done with |
@ronso0 So far, I am assigning effects to the FX units to match the controller if the effects unit slots are empty, at initialisation time of the mapping. I have this working, but upgrading to 2.5 changed the list of available effects and so my hard coded assignments are off. Thanks. |
Nope, and actually hard-coding effects wouldn't be ideal anyways. |
Please forgive me, I'm getting there slowly. I have been quite confused by the suggestion to use QuickEffects here in this PR (and weirdly in the mapping file in a comment). In Serato Lite the filter knobs (directly under the EQ knobs) only ever activate a filter* and are nothing to do with the 6 FX preset buttons. This is why I was trying to preset the main effects units to match the buttons on the controller. A fundamental question here is - is this mapping attempting to best reproduce the behaviour of the controller in Serato Lite, or is this mapping trying to match Mixxx? I don't know the answer and I don't have any connection with the original authors. Possible ways forward:
There is no good option but I favour 3. After reading the manual, complaining in the forum or just figuring it out, behaviour similar to Serato can be achieved. Thoughts? Anyone? ( * There is an option to switch it to a "dub echo" effect but it's well hidden enough that I never found it when I used Serato.. ) |
@ChrisTallon option 3 worked well for all users of the mapping. @ronso0 what's your thoughts on this? |
There is no dedicated Filter effect slot/bank/unit in Mixxx. Effects are available in QuickeEffect unit (just one slot) and standard effect units (currently 3 slots but expandable). Regarding the labeled effect toggles: So yes, the quick fix is to leave the effect buttons unmapped for now and improve the situation in followup PRs. |
In Serato the 6 effect buttons configure that single effect in slot number 1 of the main effects unit. Then the on/off/hold flappy switches are used to activate it. The knobs labelled "Filter" directly under the EQs are equivalent to Mixxx's QuickEffects but hard set to "filter". (Or dub-echo if you're lucky enough to find it) and are never affected by the 6 select buttons. User qgazq appears to have designed the mapping of the Mixtrack controls to Mixxx effects units, and explains here: https://github.com/qgazq/mixxx_numark_mixtrack_platinum_fx/blob/main/README.md#effects So, leaving the code as-is, how about this as an addition to the manual? Preview: |
Thanks, got it! To get the Serato behavior
Besides the required setup, this makes it hard to use these effect units with decks / a specfic deck only, for example with another controller or just the GUI / keyboard, so I'd vote for not making this the (hard-coded) default. But this is a perfect case for controller settings (example for MIDI mapping: xml part, js part): a checkbox "Use effect toggles for Main output" or something. |
@ronso0 can we aim for milestone 2.5.1? |
Sure we can aim for that : ) This manual still states that the FX buttons select certain preset which is not implemented in mixxxdj/mixxx#12872 (which has stalled), other than that this PR looks good I think. |
Updated instruction
FX Buttons will need to be assigned with the mixxx `Effects <https://manual.mixxx.org/2.5/en/chapters/effects#effects>`__ selectors in the graphical interface.
@ronso0 updated. |
please rebase on 2.5 to fix the CI. 2.4 CI is abandoned and broken. |
Manual for mixxxdj/mixxx#12872
Preview:
https://deploy-preview-623--mixxx-manual.netlify.app/hardware/controllers/numark_mixtrack_platinum_fx