Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Manual 2.1.x updates #59

Merged
merged 74 commits into from
Apr 15, 2018
Merged

Conversation

esbrandt
Copy link
Contributor

@esbrandt esbrandt commented Jun 24, 2017

This PR aims to document the following user visible changes, merged to https://github.com/mixxxdj/mixxx/master since the latest stable release.

This is my filter on https://github.com/mixxxdj/mixxx/pulls

is:pr is:closed merged:>=2015-12-29 sort:updated-asc

TODO

Note:
I will not cover effects in this PR (crossed out bullet points), since #64 is already in progress

esbrandt added 30 commits June 18, 2017 13:16
… for Windows. List recommended ways of installing the client.
…es. Add non-duplicate info to the text where applicable.
…ous version. For even older versions, users can follow the link to the Launchpad.net page.
… respectively ) to macOS. Bulk rename all occurrences across the manual, and go with the current name.
…ucts into Mixxx´ playlists OR crates. Also update list of supported playlist formats, and use ``third-party`` instead of ``3rd party`` (translator trap)
``--debugAssertBreak``
``--logLevel``
``--controllerDebug``
mixxxdj/mixxx#1265
mixxxdj/mixxx/mixxxdj#118
mixxxdj/mixxx#1004
esbrandt added 15 commits April 14, 2018 14:32
…ates root element. See mixxxdj/mixxx#945.

Emphasize, that importing from existing playlists/crates will result in bulk-adding the content to the single selected playlist/crate.
…in a table. Use :file: role to highlight file suffixes in text.
Copy link
Member

@rryan rryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks a bunch. I skimmed for language / spelling and things looked good. Just some tiny nits. I think we should merge ASAP even if you aren't done yet, so that we can include these changes in the PDF that we bundle in the actual release build.

@@ -369,8 +366,17 @@ choose to create them in the preferences.
Record your mix to disk
-----------------------

.. versionadded:: 2.0
Displays the duration of the recording.
.. versionadded:: 2.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.0 ? We aren't to 2.10 ... yet! :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO these "version added" notices clutter the manual. They're good for release announcements, but I don't know why someone reading the manual would care when a feature was added.

<https://lists.sourceforge.net/lists/listinfo/mixxx-devel>`_
* Join our :term:`IRC` channel, #mixxx on `Freenode <http://www.freenode.net/>`_
<https://sourceforge.net/projects/mixxx/lists/mixxx-devel>`_
* Join our :term:`IRC` channel, #mixxx on `Freenode <https://freenode.net/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace IRC with Zulip?

@@ -409,6 +420,10 @@ Edit metadata of audio files
.. sectionauthor::
S.Brandt <[email protected]>

.. versionadded:: 2.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.0

@@ -531,12 +550,19 @@ mixing or for using Mixxx as media player.

The Auto DJ features in detail:

.. versionadded:: 2.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.0


Browse - Loading remote tracks
==============================
Computer - Loading remote tracks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"remote" is an odd word here. What about "Loading tracks from anywhere on your computer" ?

**Track Title**
The title of the track that was loaded into a deck is displayed on top. This
is the same as the title listed under the :guilabel:`Title` column heading in
the Mixxx library. This information is initially loaded from the track's
:term:`metadata`.
:term:`metadata`. Is the metadata missing, parse the title and the artist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the metadata is missing, the title and artist are guessed from the filename."

@@ -135,8 +138,9 @@ separate waveforms. Select your preferred appearance in
Mixxx alternative skin (Deere) - Separate waveforms

.. warning :: If you have a slower computer and notice performance issues with
Mixxx, try to lower the frame rate or change the waveform type in
:menuselection:`Preferences --> Waveforms`.
Mixxx, try to lower the frame rate or change the type for waveform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flows a little better?

"try lowering the frame rate or changing the waveform type in :menuselection:`Preferences --> Interface --> Waveforms"

@Be-ing
Copy link
Contributor

Be-ing commented Apr 15, 2018

It looks like there are still some merge conflicts.

@esbrandt
Copy link
Contributor Author

It looks like there are still some merge conflicts.

New conflicts after yesterdays #64 merge, will have a look.

# Conflicts:
#	source/chapters/djing_with_mixxx.rst
#	source/chapters/example_setups.rst
#	source/chapters/user_interface.rst

Manually fixed conflicts
…s allows to use substitutions ( replacement images or text, as defined in ``source/shortcuts.rstext``) that can be included in the chapter.
@@ -3,7 +3,7 @@

# You can set these variables from the command line.
SPHINXOPTS =
SPHINXBUILD = sphinx-build-3
SPHINXBUILD = sphinx-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry that slipped into a commit.

@Be-ing Be-ing merged commit 3705349 into mixxxdj:manual-2.1.x Apr 15, 2018
@Be-ing
Copy link
Contributor

Be-ing commented Apr 15, 2018

Thanks! I think we're good to go for the 2.1 release. Now that we have continuous deployment for the manual, we can continue to work on it after the release. There is always more work to do, but this is a good state for packaging the PDF for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants