Add Pioneer DDJ SB3 documentation

[jevilalta]

Hi

Submitting the DDJ SB3 documentation. Pull request for the mapping itself is: mixxxdj/mixxx#3821.

[Holzhaus]

Thanks! This already looks promising.

Can you add documentation regarding the audio setup and the performance pad modes, e. g.:

• https://manual.mixxx.org/2.3/en/hardware/controllers/roland_dj_505.html#audio-setup
• https://manual.mixxx.org/2.3/en/hardware/controllers/roland_dj_505.html#hot-cue-mode

[jevilalta]

Thanks! This already looks promising.

Can you add documentation regarding the audio setup and the performance pad modes, e. g.:

* https://manual.mixxx.org/2.3/en/hardware/controllers/roland_dj_505.html#audio-setup

* https://manual.mixxx.org/2.3/en/hardware/controllers/roland_dj_505.html#hot-cue-mode

Yep. I'll add it.

[jevilalta]

Hi

I've just pushed the latest version with both audio setup and hotcue information. Let me know if anything else is needed.

[Holzhaus]

Thanks. Can you please open the files in Inkscape and save them as "Optimized SVGs" to reduce the file size?

[Holzhaus]

Thanks. Some comments regarding the button mapping itself.

[jevilalta]

I've saved the SVG files as optimized with the default settings. Some files reduced a good amount but let me know if I should change any defaults. Not an Inkscape power user...

[Holzhaus]

Please merge Dancephy#1

[jevilalta]

Hi, I am done with the changes requested. Let me know if I missed anything.

[Swiftb0y]

Thanks for the high quality figures. Unfortunately, some are a bit inconsistent in their text color, some have transparent text and others have white text (even mixed in the same figure). This doesn't matter much when viewing on a white background, but it does make some text unreadable when viewing the page with inverted colors.

[jevilalta]

So do we want to go with 8 hotcues instead of 4?

[jevilalta]

Thanks for the high quality figures. Unfortunately, some are a bit inconsistent in their text color, some have transparent text and others have white text (even mixed in the same figure). This doesn't matter much when viewing on a white background, but it does make some text unreadable when viewing the page with inverted colors.

How do I invert the colors? I am using a dark theme and it does not change the white background on the manual.

[Swiftb0y]

I'm using a browser plugin called "Dark Reader". I'm not saying you should make the graphics usable to accommodate for this case, it just made me question the quality of SVGs a bit. So I'd like you to ask to go through those graphics and make sure there aren't any hidden surprises such as duplicated objects laying ontop each other and so forth. Issues like that probably also explain the size (850KB is still very large for essentially just a schematic).

[Be-ing]

The pad grid SVGs are broken for me:

[jevilalta]

The pad grid SVGs are broken for me:

I uploaded a new version of the pad grid. The issue was not obvious to me but re-exported the image with some cleanup.

[jevilalta]

i think that's the last of the requested changes, but lmk if anything else needs to be changed

[Swiftb0y]

Please fix the stuff pre-commit complains about too

[jevilalta]

I've made the last change and re-ran all the pre-commit checks. They all come out ok:

[jevilalta]

Seems like broken links in one of the other controller's docs is causing the error now.

[Swiftb0y]

Thats fine. Ignore it.

[Swiftb0y]

Are you comfortable with rebasing for cleaning up the commit history? If not, thats fine too.

[jevilalta]

Are you comfortable with rebasing for cleaning up the commit history? If not, thats fine too.

I can give it a shot. Do you want just one commit with everything?

[Holzhaus]

Are you comfortable with rebasing for cleaning up the commit history? If not, thats fine too.

If you consider this ready to merge, you can also use "squash-and-merge" directly from the GitHub UI.

[Swiftb0y]

I can give it a shot. Do you want just one commit with everything?

No I would've preferred something more fine grained, but not too fine. I guess its a matter of taste so there isn't really one way to do it right. I think I'll just squash and merge as Jan suggested.