Statamic 5 #3
Merged
Statamic 5 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preloading seems to be a recent addition to the Spatie package, so this commit updates the tests to accomodate it: spatie/laravel-google-fonts#42
This Core PR changed how to manually configure sites: statamic/cms#9632
|
Thanks for this @duncanmcclean, I really appreciate it! |
|
No problem! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the addon to be compatible with Statamic 5.
Apologies for the early PR - I use this addon on my personal site and wanted to have a PR to patch in so I can deploy the alpha. Feel free to ignore until it's properly released 😆
Changes:
composer.lockfile from version control (it shouldn't be committed for packages)statamic/cmsversion constraint incomposer.jsonTestCaseAddonTestCaseclass which'll do all the bootstrapping stuff that previously had to be done manually. See the docssetConfigmethod was removed in favour ofsetSites.preloadparameter on Spatie'sGoogleFontsclass. I've updated the mock and the config to make this work.From what I can tell, everything seems to be working fine with these changes. Although, obviously, you know this addon better than I do so I might have missed something.